From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 771D2374C for ; Wed, 25 Nov 2015 09:38:51 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 7F11C3298; Wed, 25 Nov 2015 08:38:50 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-169.ams2.redhat.com [10.36.4.169]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAP8cnJC030547; Wed, 25 Nov 2015 03:38:49 -0500 To: Stephen Hemminger References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <20151124144638.0b659e7d@xeon-e3> From: Panu Matilainen Message-ID: <56557398.3020600@redhat.com> Date: Wed, 25 Nov 2015 10:38:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151124144638.0b659e7d@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2015 08:38:51 -0000 On 11/25/2015 12:46 AM, Stephen Hemminger wrote: > On Tue, 24 Nov 2015 16:31:17 +0200 > Panu Matilainen wrote: > >> The physically linked-together combined library has been an increasing >> source of problems, as was predicted when library and symbol versioning >> was introduced. Replace the complex and fragile construction with a >> simple linker script which achieves the same without all the problems, >> remove the related kludges from eg mlx drivers. >> >> Since creating the linker script is practically zero cost, remove the >> config option and just create it always. >> >> Based on a patch by Sergio Gonzales Monroy, linker script approach >> initially suggested by Neil Horman. >> >> Suggested-by: Sergio Gonzalez Monroy >> Suggested-by: Neil Horman >> Signed-off-by: Panu Matilainen > > But it now means distros have to ship 20 libraries which seems like > a step back. That's how Fedora and RHEL are shipping it already and nobody has so much as noticed anything strange, much less complained about it. 20 libraries is but a drop in the ocean on a average distro. But more to the point, distros will prefer 50 working libraries over one that doesn't. The combined library as it is simply is no longer a viable option. Besides just being broken (witness the strange hacks people are coming up with to work around issues in it) its ugly because it basically gives the middle finger to all the effort going into version compatibility, and its also big. Few projects will use every library in DPDK, but with the combined library they're forced to lug the 800 pound gorilla along needlessly. - Panu -