From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8B692C312 for ; Thu, 26 Nov 2015 08:39:12 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D9A635BA1B; Thu, 26 Nov 2015 07:39:11 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-17.ams2.redhat.com [10.36.4.17]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQ7dAmL009722; Thu, 26 Nov 2015 02:39:10 -0500 To: Thomas Monjalon , declan.doherty@intel.com References: <1448473135-19604-1-git-send-email-thomas.monjalon@6wind.com> From: Panu Matilainen Message-ID: <5656B71D.7030704@redhat.com> Date: Thu, 26 Nov 2015 09:39:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448473135-19604-1-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2015 07:39:12 -0000 On 11/25/2015 07:38 PM, Thomas Monjalon wrote: > The crypto API is in an early state. > It requires more discussions and experiments to declare it stable, > as discussed in http://dpdk.org/ml/archives/dev/2015-November/028634.html > > A documentation section will be required in the guides. > > Signed-off-by: Thomas Monjalon > --- [...] > --- a/config/common_bsdapp > +++ b/config/common_bsdapp > @@ -310,6 +310,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y > > # > # Compile generic crypto device library > +# EXPERIMENTAL: API may change without prior notice > # > CONFIG_RTE_LIBRTE_CRYPTODEV=y > CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n > diff --git a/config/common_linuxapp b/config/common_linuxapp > index eaad8d6..2866986 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y > > # > # Compile generic crypto device library > +# EXPERIMENTAL: API may change without prior notice > # > CONFIG_RTE_LIBRTE_CRYPTODEV=y > CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n [...] I think an experimental library which declares itself exempt from the ABI policy should not be compiled by default. That way anybody wanting to try it out will be forced to notice the experimental status. More generally / longer term, perhaps there should be a CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and defaults to off. - Panu -