From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 04F3E2A1A for ; Sun, 29 Nov 2015 10:07:48 +0100 (CET) Received: by wmuu63 with SMTP id u63so95772998wmu.0 for ; Sun, 29 Nov 2015 01:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudius-systems-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=GSG04ZzPpgt7o4k5j8tR5AlN+0/dnbZVF2M3HGBOpVQ=; b=jUAcxA8U5QxoThRxBD376NMHD1Oq0dJM/1mdFa2rr8DV0LgCRIOko4t1y3oitaujc5 MhNfjYFz5UPHI1TiR63eBBaLltm1lBu/S3kC9ahLXy7j85ZnrPkr3Du68Q+ylnBvspM0 6pNtYGrQPkUFkU+iDQyzcPjvF89sF7XJtlRy9Z6R+4L4brQplQDCdgfUsof5HnP1I1Cx Y2HFp27SlXqk/fo2ktWyyu4EGh1Iaeo76FZy7PR/mT2aZtNWpB2sUFPUfFdEWKLTed/E ETT4pMa8t/AcGjTAneAEwOVT9svW3ZmN2e54+cdxmwvk6OjOmLcImrNge8Y1Dng1ASSN CSOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=GSG04ZzPpgt7o4k5j8tR5AlN+0/dnbZVF2M3HGBOpVQ=; b=dzegiBEE9oCDy0qVwwQKw7cTL7fk6AD/oj6zK6nGoqSe7paJ4fJn03JGGf5Ubfw6WT YCSQTq2v56Us2br8uv+xoLGa1Dgj6Lphl7CK2ifwqM0llcw3a9XkE1ud/NqGMe2WX56H dWmmTULtSyGoMQY6jMurrSH4nCWdTR9hZsrunugSakAk74y/276RZK5lPqn4lDpvysoS pzUYf5pTW3MnXXbalpO2SHGDDKIvGgxEsItRMjuT0LdMtiMZXh651Tf4EfBAWLEQSrQ7 jzFtTcVboKH2iXM6TSzklUhDd2t3CFzj5Cw6VGHN47D6RyIizSrvUrasErrKHB8EkUJ+ lFOg== X-Gm-Message-State: ALoCoQmHQIwfESN88T2kjH6lSZ+iA7ASBVla3YLChFRCQ0dHuxz6MxCPKgKBMXjG2FEH8dl4j0SK X-Received: by 10.28.146.18 with SMTP id u18mr20030549wmd.72.1448788067844; Sun, 29 Nov 2015 01:07:47 -0800 (PST) Received: from [10.0.0.170] ([37.142.229.250]) by smtp.googlemail.com with ESMTPSA id cw3sm41054520wjb.26.2015.11.29.01.07.46 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 Nov 2015 01:07:47 -0800 (PST) To: Thomas Monjalon , dev@dpdk.org References: <13076727.eWbPQotoSK@xps13> From: Vlad Zolotarov Message-ID: <565AC060.1060903@cloudius-systems.com> Date: Sun, 29 Nov 2015 11:07:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <13076727.eWbPQotoSK@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] API feature check _HAS_ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2015 09:07:48 -0000 On 11/26/15 22:35, Thomas Monjalon wrote: > When introducing LRO, Vlad has defined the macro RTE_ETHDEV_HAS_LRO_SUPPORT: > http://dpdk.org/browse/dpdk/commit/lib/librte_ether/rte_ethdev.h?id=8eecb329 > > It allows to use the feature without version check (before the release or > after a backport). > Do you think it is useful? > Should we define other macros RTE_[API]_HAS_[FEATURE] for each new feature > or API change? The main purpose of the above macro was to identify the presence of the new field in the rte_eth_rxmode during the period of time when there was no other way to know it. Once this may be concluded based on the release version I see no reason to keep it. > It's time to fix it before releasing the 2.2 version.