From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 92C7E5AA0 for ; Sun, 29 Nov 2015 10:43:18 +0100 (CET) Received: by wmww144 with SMTP id w144so102622512wmw.0 for ; Sun, 29 Nov 2015 01:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudius-systems-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=wjXBd8BoJvMJlJVMOD30/SLU1CAMw/hrzI2hJ27hsIQ=; b=CUslp/MsvkYL1CAiRgTQ4HtIJ0FnbjKhRDPCrkrQw7sm8oBKaxRaNP4OMzr+VDzGrL JSrOAr/ORJpFU+BmhmAFKEvaUuB8s3n4Gl43LECrOfr7tmQw4Ao87XAPtcWrf5r6AIHD uPfXKdTZszYgrNVjoGR/8ZdRwFz/tUTyS4hCWqgM4oqcFxNGav/owYvdmzxP1VIXaJwQ NLBLgth00+dWLJnLONA2pLsNjs9G2S5azl0IsBaLeFL7jB9xLsD83tMMGbAxPC4WmThH 5soJFQSeNAhIT5jvjUrlk8n1KwqoSS9HHSaBd9MJ0qUU/wr3jvxTdVEraboJKca96QZ4 7U/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=wjXBd8BoJvMJlJVMOD30/SLU1CAMw/hrzI2hJ27hsIQ=; b=EHkhA5RnQMQZCw3liw6ExDY1W0y/VLKSpfnXA0G8sxv7j7Y6plH8FG9+y9zibZZ0Y7 mUSeIf1OqJ62S0oLQzAlb/avFzqpGTFdrQn3jNGaYpISjCjqtRmf33Kt8bu05Q4gOqUx 0TcgWeh1xIs/xlaUoHBnxIT97Saif3oHo6tkpLEl48Lb5+2FJeBJ02FlzNCLXv0mc1kA T3apqcf+a6xRfwCC6sA4WGzas4tah1+hiFl9FVfAJGljStDZFMoqphmYcfZxDAfqogBX pDANy7C9gi9h4q280HVXSZEg52JqqeDCScdomzJ/f0zqlbDCeRdRsIbrWU2XmlTxlvnG aCAg== X-Gm-Message-State: ALoCoQlfXs1GZncjQZCfStQ0a23MkX0Ani86NCeH4yrOgJMCJLfq1rf8zTm8M6icf7KDbEziYUsv X-Received: by 10.28.72.136 with SMTP id v130mr20279499wma.60.1448790198440; Sun, 29 Nov 2015 01:43:18 -0800 (PST) Received: from [10.0.0.170] ([37.142.229.250]) by smtp.googlemail.com with ESMTPSA id hw1sm41440265wjb.6.2015.11.29.01.43.17 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 Nov 2015 01:43:17 -0800 (PST) To: Gleb Natapov References: <13076727.eWbPQotoSK@xps13> <565AC060.1060903@cloudius-systems.com> <20151129091011.GG19023@scylladb.com> From: Vlad Zolotarov Message-ID: <565AC8B4.7070403@cloudius-systems.com> Date: Sun, 29 Nov 2015 11:43:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151129091011.GG19023@scylladb.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] API feature check _HAS_ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2015 09:43:18 -0000 On 11/29/15 11:10, Gleb Natapov wrote: > On Sun, Nov 29, 2015 at 11:07:44AM +0200, Vlad Zolotarov wrote: >> >> On 11/26/15 22:35, Thomas Monjalon wrote: >>> When introducing LRO, Vlad has defined the macro RTE_ETHDEV_HAS_LRO_SUPPORT: >>> http://dpdk.org/browse/dpdk/commit/lib/librte_ether/rte_ethdev.h?id=8eecb329 >>> >>> It allows to use the feature without version check (before the release or >>> after a backport). >>> Do you think it is useful? >>> Should we define other macros RTE_[API]_HAS_[FEATURE] for each new feature >>> or API change? >> The main purpose of the above macro was to identify the presence of the new >> field in the rte_eth_rxmode during the >> period of time when there was no other way to know it. Once this may be >> concluded based on the release version I see no >> reason to keep it. >> > Concluding things based on release version does not work so well for > back ports. In that case the existing applications won't be able to enjoy the feature with the older releases with the backport - that's true. Having this flag has it's benefits (e.g. the corresponding ifdefs are much more readable), however to be consistent we'd rather define this type of flags for other features too like Thomas wrote above. I'm not against this approach too... > >>> It's time to fix it before releasing the 2.2 version. > -- > Gleb.