From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Guzik <john@shieldxnetworks.com>, Yong Wang <yongwang@vmware.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] vmxnet3 driver - vlan offload is on end descriptor
Date: Thu, 07 Apr 2016 19:34:41 +0200 [thread overview]
Message-ID: <5660045.mydYX4O3xK@xps13> (raw)
In-Reply-To: <SN1PR20MB028564DE6A82A22983157757DC900@SN1PR20MB0285.namprd20.prod.outlook.com>
2016-04-07 17:11, John Guzik:
> With the new jumbo frame patch a latent bug has appeared to have been uncovered: the VLAN offload is on the last rx descriptor, when rcd->eop is true, not the first rx descriptor, when rcd->sop is true and rcd->eop could be false.
> Most likely the reason this has not been seen before is that for non-jumbo frames rcd->eop has always been true when rcd->sop is true as well.
Thanks for reporting.
Please Yong, could you confirm?
John, 2 tags are needed to be applied:
Fixes: commit-origin-of-the-bug
Signed-off-by:
Please check http://dpdk.org/dev#send for more details. Thanks
next prev parent reply other threads:[~2016-04-07 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:11 John Guzik
2016-04-07 17:34 ` Thomas Monjalon [this message]
2016-04-07 18:22 ` Yong Wang
2016-04-07 17:35 ` Stephen Hemminger
2016-04-12 23:08 ` [dpdk-dev] [PATCH] vmxnet3: VLAN tag on end packet, not first John Guzik
2016-05-10 15:04 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5660045.mydYX4O3xK@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=john@shieldxnetworks.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).