DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] examples/l3fwd-power: fix telemetry command registration
@ 2025-10-06 10:10 Sivaprasad Tummala
  2025-11-06 13:41 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Sivaprasad Tummala @ 2025-10-06 10:10 UTC (permalink / raw)
  To: mb, david.marchand, ktraynor, thomas, konstantin.ananyev,
	konstantin.v.ananyev, bruce.richardson, maxime.coquelin, aconole,
	ferruh.yigit
  Cc: dev, ciara.power, stable

Telemetry command registration fails if the command name contains
characters other than alphanumeric, underscore (_), and forward
slash (/).

The l3fwd-power example previously used "/l3fwd-power/stats"
as telemetry command, which includes a hyphen (-) and causes
registration failure.

This patch fixes the issue by replacing the hyphen with an
underscore, changing the command to "/l3fwd_power/stats"

Fixes: a35919a1139b ("examples/l3fwd-power: use new telemetry")
Cc: ciara.power@intel.com
Cc: stable@dpdk.org

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 examples/l3fwd-power/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index e27b8531b5..f9ce9e6698 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2910,7 +2910,7 @@ main(int argc, char **argv)
 			rte_spinlock_init(&stats[lcore_id].telemetry_lock);
 		}
 		rte_timer_init(&telemetry_timer);
-		rte_telemetry_register_cmd("/l3fwd-power/stats",
+		rte_telemetry_register_cmd("/l3fwd_power/stats",
 				handle_app_stats,
 				"Returns global power stats. Parameters: None");
 		rte_eal_mp_remote_launch(main_telemetry_loop, NULL,
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] examples/l3fwd-power: fix telemetry command registration
  2025-10-06 10:10 [PATCH] examples/l3fwd-power: fix telemetry command registration Sivaprasad Tummala
@ 2025-11-06 13:41 ` Bruce Richardson
  2025-11-11 18:25   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2025-11-06 13:41 UTC (permalink / raw)
  To: Sivaprasad Tummala
  Cc: mb, david.marchand, ktraynor, thomas, konstantin.ananyev,
	konstantin.v.ananyev, maxime.coquelin, aconole, ferruh.yigit,
	dev, ciara.power, stable

On Mon, Oct 06, 2025 at 10:10:58AM +0000, Sivaprasad Tummala wrote:
> Telemetry command registration fails if the command name contains
> characters other than alphanumeric, underscore (_), and forward
> slash (/).
> 
> The l3fwd-power example previously used "/l3fwd-power/stats"
> as telemetry command, which includes a hyphen (-) and causes
> registration failure.
> 
> This patch fixes the issue by replacing the hyphen with an
> underscore, changing the command to "/l3fwd_power/stats"
> 
> Fixes: a35919a1139b ("examples/l3fwd-power: use new telemetry")
> Cc: ciara.power@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] examples/l3fwd-power: fix telemetry command registration
  2025-11-06 13:41 ` Bruce Richardson
@ 2025-11-11 18:25   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2025-11-11 18:25 UTC (permalink / raw)
  To: Sivaprasad Tummala
  Cc: stable, mb, david.marchand, ktraynor, konstantin.ananyev,
	konstantin.v.ananyev, maxime.coquelin, aconole, ferruh.yigit,
	dev, ciara.power, Bruce Richardson

06/11/2025 14:41, Bruce Richardson:
> On Mon, Oct 06, 2025 at 10:10:58AM +0000, Sivaprasad Tummala wrote:
> > Telemetry command registration fails if the command name contains
> > characters other than alphanumeric, underscore (_), and forward
> > slash (/).
> > 
> > The l3fwd-power example previously used "/l3fwd-power/stats"
> > as telemetry command, which includes a hyphen (-) and causes
> > registration failure.
> > 
> > This patch fixes the issue by replacing the hyphen with an
> > underscore, changing the command to "/l3fwd_power/stats"
> > 
> > Fixes: a35919a1139b ("examples/l3fwd-power: use new telemetry")
> > Cc: ciara.power@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-11 18:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-06 10:10 [PATCH] examples/l3fwd-power: fix telemetry command registration Sivaprasad Tummala
2025-11-06 13:41 ` Bruce Richardson
2025-11-11 18:25   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).