From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8FAED958E for ; Mon, 7 Dec 2015 09:51:59 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id BE7178CF76; Mon, 7 Dec 2015 08:51:58 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-85.ams2.redhat.com [10.36.5.85]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB78pv1X016220; Mon, 7 Dec 2015 03:51:57 -0500 To: Thomas Monjalon , Fan Zhang References: <1447866563-19121-1-git-send-email-roy.fan.zhang@intel.com> <1584130.bSMaiaJVtY@xps13> From: Panu Matilainen Message-ID: <566548AC.6020807@redhat.com> Date: Mon, 7 Dec 2015 10:51:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1584130.bSMaiaJVtY@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] ip_pipeline: add flow actions pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 08:51:59 -0000 On 12/07/2015 03:17 AM, Thomas Monjalon wrote: > 2015-11-18 17:09, Fan Zhang: >> Flow actions pipeline is an extension of flow-classification pipeline. >> Some of the operations of flow classification pipeline such as traffic >> metering/marking(for e.g. Single Rate Three Color Marker (srTCM), Two >> Rate Three Color Marker trTCM)), policer can be performed separately in >> flow action pipeline to avoid excessive computational burden on the CPU >> core running the flow-classification pipeline. The Flow action pipeline >> implements various function such as traffic metering, policer, stats. >> Traffic mettering can configured as per the required context, for >> examples- per user, per traffic class or both. These contexts can be >> applied by specifying parameters in configuration file as shown below; >> >> [PIPELINE1] >> type = FLOW_ACTIONS >> core = 1 >> pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0 >> pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0 >> n_flows = 65536 >> n_meters_per_flow = 1 >> flow_id_offset = 158 >> ip_hdr_offset = 142 >> color_offset = 64 >> >> The entries of flow and dscp tables of flow actions pipeline can be >> modified through command-line interface. The commands to add or delete >> entries to the flow table, DSCP(differentiated services code point) >> table and for statistics collection, etc have been included. The key >> functions such as Traffic Metering/marking and policer functions have >> been implemented as flow-table action handler. >> >> Signed-off-by: Jasvinder Singh >> Signed-off-by: Fan Zhang >> Acked-by: Cristian Dumitrescu > > Applied, thanks > The patch tries to include pipeline_flow_actions.h which doesn't exist, making the ip_pipeline example unbuildable. Seems like a case of forgotten "git add" when creating the patch... - Panu -