DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: Panu Matilainen <pmatilai@redhat.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags
Date: Mon, 7 Dec 2015 14:49:33 +0100	[thread overview]
Message-ID: <56658E6D.6060901@netinsight.net> (raw)
In-Reply-To: <db3a1cbec374683d05b485b51c1604d3aa1b3429.1449493003.git.pmatilai@redhat.com>

On 2015-12-07 13:56, Panu Matilainen wrote:
> Starting with commit 9aa2053c6e81493b23346ff4e387903560de5c81
> EXTRA_CFLAGS is sometimes being passed to the compiler without
> WERROR_FLAGS which can cause spurious warnings by the dozen,
> for example with when compiling with EXTRA_CFLAGS="-Wformat-security":
> 
> cc1: warning: -Wformat-security ignored without -Wformat [-Wformat-security]
> 
> Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage
> consistent throughout the codebase, silencing the warnings.
> [...]
> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
> index c6bb8de..28f203b 100644
> --- a/mk/rte.cpuflags.mk
> +++ b/mk/rte.cpuflags.mk
> @@ -33,7 +33,7 @@
>  # used to set the RTE_CPUFLAG_* environment variables giving details
>  # of what instruction sets the target cpu supports.
>  
> -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)
> +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)

Acked-by: Simon Kagstrom <simon.kagstrom@netinsight.net>

  reply	other threads:[~2015-12-07 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 12:56 Panu Matilainen
2015-12-07 13:49 ` Simon Kågström [this message]
2015-12-07 21:41   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56658E6D.6060901@netinsight.net \
    --to=simon.kagstrom@netinsight.net \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).