[dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags

[dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags

[Panu Matilainen]

Starting with commit 9aa2053c6e81493b23346ff4e387903560de5c81
EXTRA_CFLAGS is sometimes being passed to the compiler without
WERROR_FLAGS which can cause spurious warnings by the dozen,
for example with when compiling with EXTRA_CFLAGS="-Wformat-security":

cc1: warning: -Wformat-security ignored without -Wformat [-Wformat-security]

Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage
consistent throughout the codebase, silencing the warnings.

Fixes: 9aa2053c6e81 ("mk: influence CPU flags with user input")
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 mk/rte.cpuflags.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
index c6bb8de..28f203b 100644
--- a/mk/rte.cpuflags.mk
+++ b/mk/rte.cpuflags.mk
@@ -33,7 +33,7 @@
 # used to set the RTE_CPUFLAG_* environment variables giving details
 # of what instruction sets the target cpu supports.
 
-AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)
+AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)
 
 # adding flags to CPUFLAGS
 
-- 
2.5.0

Re: [dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags

[Simon Kågström]

On 2015-12-07 13:56, Panu Matilainen wrote:
> Starting with commit 9aa2053c6e81493b23346ff4e387903560de5c81
> EXTRA_CFLAGS is sometimes being passed to the compiler without
> WERROR_FLAGS which can cause spurious warnings by the dozen,
> for example with when compiling with EXTRA_CFLAGS="-Wformat-security":
> 
> cc1: warning: -Wformat-security ignored without -Wformat [-Wformat-security]
> 
> Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage
> consistent throughout the codebase, silencing the warnings.
> [...]
> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
> index c6bb8de..28f203b 100644
> --- a/mk/rte.cpuflags.mk
> +++ b/mk/rte.cpuflags.mk
> @@ -33,7 +33,7 @@
>  # used to set the RTE_CPUFLAG_* environment variables giving details
>  # of what instruction sets the target cpu supports.
>  
> -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)
> +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)

Acked-by: Simon Kagstrom <simon.kagstrom@netinsight.net>

Re: [dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags

[Thomas Monjalon]

2015-12-07 14:49, Simon Kågström:
> On 2015-12-07 13:56, Panu Matilainen wrote:
> > Starting with commit 9aa2053c6e81493b23346ff4e387903560de5c81
> > EXTRA_CFLAGS is sometimes being passed to the compiler without
> > WERROR_FLAGS which can cause spurious warnings by the dozen,
> > for example with when compiling with EXTRA_CFLAGS="-Wformat-security":
> > 
> > cc1: warning: -Wformat-security ignored without -Wformat [-Wformat-security]
> > 
> > Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage
> > consistent throughout the codebase, silencing the warnings.
> 
> Acked-by: Simon Kagstrom <simon.kagstrom@netinsight.net>

Applied, thanks