From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2944695C8 for ; Mon, 7 Dec 2015 15:09:16 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6E63940C5B; Mon, 7 Dec 2015 14:09:15 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-85.ams2.redhat.com [10.36.5.85]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB7E9ED4017924; Mon, 7 Dec 2015 09:09:14 -0500 To: dev@dpdk.org References: From: Panu Matilainen Message-ID: <56659309.6010305@redhat.com> Date: Mon, 7 Dec 2015 16:09:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: Re: [dpdk-dev] [PATCH v2] scripts: support any legal git revisions as abi validation range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 14:09:16 -0000 On 12/03/2015 04:05 PM, Panu Matilainen wrote: > In addition to git tags, support validating abi between any legal > gitrevisions(7) syntaxes, such as "validate-abi.sh -1 . " > "validate-abi.sh master mybranch " etc in addition to > validating between tags. Makes it easier to run the validator > for in-development work. > > Signed-off-by: Panu Matilainen > Acked-by: Neil Horman > --- > > v2 changes: > - update usage and error messages to match new behavior > - update documentation too (as suggested by John McNamara) > I started wondering why this didn't get applied along with the other abi-validator changes and noticed this is sitting in patchwork in "changes requested" state, which doesn't seem right: v2 added the requested documentation. The discussion around this patch did spur another request (ability to pass parallel build flags to make) but that's entirely unrelated, so it shouldn't hold up this one. I've no intention of sending a v3 of this patch because AFAIK there's nothing to fix and the make-flags thing does not belong here, but resetting the state to "new" by myself feels like cheating or something :) So what's the correct action here? There's preciously little documentation about expected patchwork workflow and such. - Panu -