From: Panu Matilainen <pmatilai@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix external shared library dependencies of libraries
Date: Tue, 8 Dec 2015 13:19:30 +0200 [thread overview]
Message-ID: <5666BCC2.2080107@redhat.com> (raw)
In-Reply-To: <33721268.SXJjAvgPEg@xps13>
On 12/08/2015 12:11 PM, Thomas Monjalon wrote:
> Hi Panu,
>
> 2015-12-08 10:30, Panu Matilainen:
>> --- a/lib/librte_vhost/Makefile
>> +++ b/lib/librte_vhost/Makefile
>> @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user
>> else
>> CFLAGS += -I vhost_cuse -lfuse
>> LDFLAGS += -lfuse
>> +LDLIBS += -lfuse
>> endif
>>
>> ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
>> LDFLAGS += -lnuma
>> +LDLIBS += -lnuma
>> endif
>
> It looks weird to have to declare the dependencies both in
> LDFLAGS and LDLIBS. What is the reason?
> Can we improve it?
I'd say its just an artifact of the dpdk build system evolution and
surely we can improve it, but I'd leave it post 2.2 to avoid breaking
anything now.
I'm planning further work in this area and one of the things on my TODO
list is to look into the LDFLAGS/LDLIBS duplication. Technically, LDLIBS
should only contain the libraries to link, and all the others directives
(such as linker path etc) should go to LDFLAGS.
- Panu -
next prev parent reply other threads:[~2015-12-08 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 8:30 Panu Matilainen
2015-12-08 10:11 ` Thomas Monjalon
2015-12-08 11:19 ` Panu Matilainen [this message]
2015-12-08 11:39 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666BCC2.2080107@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).