From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 3949858D4
 for <dev@dpdk.org>; Tue,  8 Dec 2015 12:19:33 +0100 (CET)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 by mx1.redhat.com (Postfix) with ESMTPS id 6E1DA8C1A9;
 Tue,  8 Dec 2015 11:19:32 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-5-22.ams2.redhat.com
 [10.36.5.22])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 tB8BJUVS030145; Tue, 8 Dec 2015 06:19:31 -0500
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <87f15b40e6a0cad89a9eb94dd173cd20878b591a.1449563079.git.pmatilai@redhat.com>
 <33721268.SXJjAvgPEg@xps13>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <5666BCC2.2080107@redhat.com>
Date: Tue, 8 Dec 2015 13:19:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <33721268.SXJjAvgPEg@xps13>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix external shared library dependencies
	of libraries
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 11:19:33 -0000

On 12/08/2015 12:11 PM, Thomas Monjalon wrote:
> Hi Panu,
>
> 2015-12-08 10:30, Panu Matilainen:
>> --- a/lib/librte_vhost/Makefile
>> +++ b/lib/librte_vhost/Makefile
>> @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user
>>   else
>>   CFLAGS += -I vhost_cuse -lfuse
>>   LDFLAGS += -lfuse
>> +LDLIBS += -lfuse
>>   endif
>>
>>   ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
>>   LDFLAGS += -lnuma
>> +LDLIBS += -lnuma
>>   endif
>
> It looks weird to have to declare the dependencies both in
> LDFLAGS and LDLIBS. What is the reason?
> Can we improve it?

I'd say its just an artifact of the dpdk build system evolution and 
surely we can improve it, but I'd leave it post 2.2 to avoid breaking 
anything now.

I'm planning further work in this area and one of the things on my TODO 
list is to look into the LDFLAGS/LDLIBS duplication. Technically, LDLIBS 
should only contain the libraries to link, and all the others directives 
(such as linker path etc) should go to LDFLAGS.

	- Panu -