From: Declan Doherty <declan.doherty@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Andriy Berestovskyy <aber@semihalf.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bond: fix LACP mempool size
Date: Mon, 14 Dec 2015 15:51:51 +0000 [thread overview]
Message-ID: <566EE597.3090200@intel.com> (raw)
In-Reply-To: <1485531.tGOVgyf9lb@xps13>
On 14/12/15 14:07, Thomas Monjalon wrote:
> 2015-12-10 22:50, Thomas Monjalon:
>> Please Declan,
>> Could you check these patches from Andriy
>> and tell how safe it is for 2.2?
>
> Declan, you have just acked 2 patches from Andriy without telling
> how safe they are for 2.2.
> Also we hadn't notice there is no Signed-off-by lines in these patches.
>
> Andriy, could you confirm your Signed-off-by according to the
> Developer's Certificate of Origin?
> (see http://www.kernel.org/doc/Documentation/SubmittingPatches)
>
Hey Thomas, sorry I didn't notice the lack of a sign-off, and git didn't
complain when I applied them, which I expected it would. Both change
sets look like they should be safe for inclusion in 2.2 as they are both
addressing valid issues but they do not effect the expected behavior of
the bonding library. I've also verified that all the bonding test unit
cases are also still passing, so they look good to me.
Regards
Declan
next prev parent reply other threads:[~2015-12-14 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 13:23 Andriy Berestovskyy
2015-12-10 21:50 ` Thomas Monjalon
2015-12-14 14:07 ` Thomas Monjalon
2015-12-14 15:51 ` Declan Doherty [this message]
2015-12-14 13:53 ` Declan Doherty
2015-12-14 15:01 ` Andriy Berestovskyy
2015-12-14 21:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566EE597.3090200@intel.com \
--to=declan.doherty@intel.com \
--cc=aber@semihalf.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).