From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 817CF256 for ; Tue, 15 Dec 2015 12:41:55 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B19D1754; Tue, 15 Dec 2015 11:41:54 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-21.ams2.redhat.com [10.36.5.21]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBFBfr2i011141; Tue, 15 Dec 2015 06:41:54 -0500 To: Thomas Monjalon , dev@dpdk.org References: <1450176434-7213-1-git-send-email-thomas.monjalon@6wind.com> <1450176434-7213-2-git-send-email-thomas.monjalon@6wind.com> From: Panu Matilainen Message-ID: <566FFC81.2010601@redhat.com> Date: Tue, 15 Dec 2015 13:41:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450176434-7213-2-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 11:41:55 -0000 On 12/15/2015 12:47 PM, Thomas Monjalon wrote: > The API has been removed but the symbols were still declared in the map. > > Fixes: a421b86a4a02 ("ethdev: remove old flow director API") > > Signed-off-by: Thomas Monjalon > --- > lib/librte_ether/rte_ether_version.map | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map > index 17a11c7..d8db24d 100644 > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -27,14 +27,6 @@ DPDK_2.2 { > rte_eth_dev_count; > rte_eth_dev_default_mac_addr_set; > rte_eth_dev_detach; > - rte_eth_dev_fdir_add_perfect_filter; > - rte_eth_dev_fdir_add_signature_filter; > - rte_eth_dev_fdir_get_infos; > - rte_eth_dev_fdir_remove_perfect_filter; > - rte_eth_dev_fdir_remove_signature_filter; > - rte_eth_dev_fdir_set_masks; > - rte_eth_dev_fdir_update_perfect_filter; > - rte_eth_dev_fdir_update_signature_filter; > rte_eth_dev_filter_ctrl; > rte_eth_dev_filter_supported; > rte_eth_dev_flow_ctrl_get; > Good spotting. What did you use find these and the ones in eal? Just thinking this seems like something that could and should be automated. - Panu -