From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C247F433F4; Tue, 28 Nov 2023 16:55:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 497E042E00; Tue, 28 Nov 2023 16:55:16 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 0F71B410FD for ; Tue, 28 Nov 2023 16:55:15 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EE6E25C0084; Tue, 28 Nov 2023 10:55:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 28 Nov 2023 10:55:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1701186911; x=1701273311; bh=TKVRqkw3YqahRUNebo4AZ6ubuH38CXmzfBq EzQda4wI=; b=S0HTqLjxjfYIAOrXR4qT7MChso6m3IW583c7vhmrDZl1vBsdG6y PdM9teRD5afQnAFRIGhty3avCbLT8olyyMuKIiq854azdYg18fqQPQNkMj4lm8aU L0JYGW1raGiwnfF7ErTvqGLdccVZCc/ORbIEqBYIDM8J2ZOaYcDAXPmDBMsy+aMF Y9i1CnD+SZSt4d4bbOjoudtxDTpZ7aUcZoLujLmrO3wjpSwC7XiKh9Z7y+Wk/esO sjisPgIGK51cfl3R0wg9fWdu9K57PvFrUXJk4cdb3sn0vOcAjMBVYI8nb09zbSwK A8yNUiPXZgyt87eFL605xxn/nkYCcjhmdxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701186911; x=1701273311; bh=TKVRqkw3YqahRUNebo4AZ6ubuH38CXmzfBq EzQda4wI=; b=kjaYG5hozQTCEs1sM1lKuVmDczINU5B9zGYS7cjCJWrfp72XhkT Ydi/FLxk4ErKywX4Qk+I+lPtC13326qCMwzRR541vFkK94ieDp2ln/Jr/85MbGNA /KyMk74nfycvlAWQRH9Imq2i96TWt4AbY/3JykpXWl2T+k7p/FBpN1GsWNJbd6Bx /iKqGopDfBN6WkWCRAn3JkoMXVYt2/iOwEhd/P1fWoLHgl5/4VQos+WX0fKbpNtk Gdjt6rdyblUgXnAyqRvVZudbrxIXAT74EdDFxQAl7nAYl1dVt044C1b1zmf79DzS 1VM6hrPt1O0pUD8jbeOR1kO6d3+maYYc90w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 10:55:10 -0500 (EST) From: Thomas Monjalon To: Ankur Dwivedi Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch Date: Tue, 28 Nov 2023 16:55:08 +0100 Message-ID: <5670179.Sgy9Pd6rRy@thomas> In-Reply-To: References: <20230303155811.2751210-1-adwivedi@marvell.com> <10886256.lvqk35OSZv@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/11/2023 15:07, Ankur Dwivedi: > >07/03/2023 13:05, Ankur Dwivedi: > >> This patch series adds a validation in checkpatch tool to check if > >> tracepoint is present in any new function added in ethdev, eventdev > >> cryptodev and mempool library. > >> > >> v5: > >> - Copied the build_map_changes function from check-symbol-change.sh to > >> check-tracepoint.sh. > >> - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh. > > > >Why did you decide to copy the function in v5, instead of having a common > >file usable by different scripts? > > > There was comments in v2 of the patch that common scripts may not work well and to keep the scripts specialized. I meant you can have a common file specialized in symbols. In general, you should reply, establish a discussion, so we share the same understanding.