From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A37738D8C for ; Fri, 18 Dec 2015 07:17:59 +0100 (CET) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NZJ003RWITX8Y70@mailout2.w1.samsung.com> for dev@dpdk.org; Fri, 18 Dec 2015 06:17:57 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-2d-5673a5157f1c Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id EF.A1.21385.515A3765; Fri, 18 Dec 2015 06:17:57 +0000 (GMT) Received: from [106.109.129.180] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NZJ00JINITWWC40@eusync3.samsung.com>; Fri, 18 Dec 2015 06:17:57 +0000 (GMT) To: "Wang, Zhihong" , "dev@dpdk.org" References: <1450326062-105574-1-git-send-email-zhihong.wang@intel.com> <5672A0E5.4040904@samsung.com> <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com> From: Ilya Maximets Message-id: <5673A514.10004@samsung.com> Date: Fri, 18 Dec 2015 09:17:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xq7qiS4vDDO7MUbB492k7k0X7zLNM Fq8urWKzmDxbyuL6hAusFpsvTmJyYPP4tWApq8fiPS+ZPOadDPTo27KKMYAlissmJTUnsyy1 SN8ugSvjw41D7AUvWCq+bJzJ2MD4irmLkZNDQsBEYsvZE1C2mMSFe+vZuhi5OIQEljJKLDy8 Bcp5wShxp/UOC0iVsIC9xM7XG5m6GDk4RAS8JVZc1oao2cAosWdNF1gDs8BxRokjv1aygzSw CehInFp9hBHE5hXQkFjYehFsHYuAqsSxhodMILaoQITExAkNrBA1ghI/Jt8DW8YpECKxeudn ZpBlzAJ6EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rpFecmFtc mpeul5yfu4kREs5fdzAuPWZ1iFGAg1GJh/cGc3GYEGtiWXFl7iFGCQ5mJRHeDROBQrwpiZVV qUX58UWlOanFhxilOViUxHln7nofIiSQnliSmp2aWpBaBJNl4uCUamA8I/cw8Xpmy8ei+atn WP91Cz/UPVsnj3mmhOHvnbv2zdxSV1Z175CfovmL8F33a5S3hubmr3v0ynXN/UOG//Yzxu25 IHz+RkxF6gO9at3jwbdYu1aumPZbbuNFCQZ9nu/8Spe/P9Uq1j0rGGSY+P7Z/oKPfasjy8XF 5l5g5jh+96D4mzjLGXuSlFiKMxINtZiLihMBk2AxAGMCAAA= Cc: "s.dyasly@samsung.com" Subject: Re: [dpdk-dev] [PATCH] Unlink existing unused sockets at start up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2015 06:17:59 -0000 On 18.12.2015 05:39, Wang, Zhihong wrote: > Yes ideally the underneath lib shouldn't meddle with the recovery logic. > But I do think we should at least put a warning in the lib function said the app should make the path available. This is another topic though :-) > Like we did in memcpy: > /** > * Copy 16 bytes from one location to another, > * locations should not overlap. > */ > Isn't it enough to have an error in the log? lib/librte_vhost/vhost_user/vhost-net-user.c:130: RTE_LOG(ERR, VHOST_CONFIG, "fail to bind fd:%d, remove file:%s and try again.\n", Best regards, Ilya Maximets.