From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66C04A0548; Thu, 8 Sep 2022 18:24:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D07F94280D; Thu, 8 Sep 2022 18:24:51 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2068.outbound.protection.outlook.com [40.107.237.68]) by mails.dpdk.org (Postfix) with ESMTP id 2283842802 for ; Thu, 8 Sep 2022 18:24:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jlrCVrNFTJqmWlcelXccoWlqDCiNAQWAuCHkZ03vRpfW7TYQiRh6HN8e4TgW2jMAvysnSsDl3fcqlzDRa75aUqOgMP5ExTbkt4Y6vloxjo/erFXOJiX9DE+0BYSvyLhlaFFPreVweVURsyVdynRF+kGkDeuh8bau5GI+5M8I+om1/qRQ6ea7MbTy3oiAUqtexuwLKh4kDUyqeojomusY1uxRKkSue4pOALd+jMfngln01sOzlQ6Y4VY7CHrdx5ncj0WvFCBoO9cbv76A/PQH1XFi8BrvaG8ao8IuybsMSPp5hz5mNXu7vqMimESyXoZTI252pqAG0TGHuqjwkgdsMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aRrP5DRya+iZplSGe7dWhwiRdCrAaTn0rcMyPypgCA8=; b=lm+aksiYuaem8j70z9WK8VZaOnGT6A/ZfebYBtnr1KhXifrACW/2DqCYf3+6Uld7cNsCJMXUnb+3BSJUKPsTIW8vzG1Fc7DHoywp65VXCBLKTqy+cOM4wHzZObepzdYOrSKF3mov9YI0tdOQskUvXLNM6mbNTWuZ50rOW4HMdFnhSwu/h/cB5QTTgTaJeBOEuTlWsuWKqnmqM5DGk3LkcgQJZWqIGqNVmf/QPxGjpcYw4IvT6SNNN5rvi/HUnZMjLzjf2bGdVEU9n+FQC7RenJZeeTxdYmZ0Bq46UvlkGH+dZuQAx6S3EPEZUP/jjb1SpVfP8hHVNlzKJqEzPmC0+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aRrP5DRya+iZplSGe7dWhwiRdCrAaTn0rcMyPypgCA8=; b=BIA/6luKSp7J8blQy9yeseHLbcUADTgDiT5vfMIQU1z9cIgXSfYmnfr1KXp72VNCZJDP6nGJHpkq+xPwRqJsCo7MiH4IZs3cY5LKrhuKp9DmOAxxMoYdmKKi3U8bngNeBxFqZAQ/28Cyek/yINbd1Lh/A+d7OzfY35aIzyX5ip0= Received: from SN7PR18CA0015.namprd18.prod.outlook.com (2603:10b6:806:f3::6) by DM6PR02MB4761.namprd02.prod.outlook.com (2603:10b6:5:fb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Thu, 8 Sep 2022 16:24:44 +0000 Received: from SN1NAM02FT0056.eop-nam02.prod.protection.outlook.com (2603:10b6:806:f3:cafe::11) by SN7PR18CA0015.outlook.office365.com (2603:10b6:806:f3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19 via Frontend Transport; Thu, 8 Sep 2022 16:24:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0056.mail.protection.outlook.com (10.97.4.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 16:24:44 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 8 Sep 2022 17:24:26 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 8 Sep 2022 17:24:26 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, heinrich.kuhn@corigine.com Received: from [10.71.194.74] (port=17001) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oWKKI-0002IC-S2; Thu, 08 Sep 2022 17:24:26 +0100 Message-ID: <56767658-8756-e1ba-77d4-c6f5fd2fd118@xilinx.com> Date: Thu, 8 Sep 2022 17:24:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v8 01/12] net/nfp: move app specific attributes to own struct Content-Language: en-US To: Chaoyong He , CC: , , Heinrich Kuhn References: <1662626702-17254-1-git-send-email-chaoyong.he@corigine.com> <1662626702-17254-2-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1662626702-17254-2-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0056:EE_|DM6PR02MB4761:EE_ X-MS-Office365-Filtering-Correlation-Id: c4e90e01-05c8-41da-7b42-08da91b6a3f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uJFDbUkXRzIy0rqLHzHcvYrV4xrsUrzPjEgy1mwO7+XcJOEwIQu4XuisHP5dZbY7afOD5hoQplDi7D9lEeJOlm7TCd9+TCBdSyx2B4gIfv0IhgZe96mK7KQo1fPfWeCRQX6WqAS4AYZB7WoJC6ojxDnUjuEj07Tw/EcYvvsDA0RjIY9ZpRAavCQe3w51Eey47WQoNZ6xv72q4YbtE/+b4ai9Y8d0tdJZy+F9MTbgZ/B0WepMssNA3Y2fG3Gx4JrCeUDlGnaiEySO1CtAthEC871KiSpe3aYoQYjz0M+GrjqfnSkzA/uztYSF1xpn7OUlwoPxm/FbbNT2K1eP5UPd3JsrzpeC2j2zcgDwri3BydQLq8mu0NGb+7tjVWQg1zI+VB1R3G8UGvMVZEJEjMWa6U015n2cACX2d7JgUMDDJxmdwjdZAFIjugFC3hrbU9117k8YslgLmgW08qoNg+YBtRhzB/Ox/SSeitUttWTcUgo413YC4JrqYxlw3paKj0q+Puz4jrgaqEbBGWQ+K2SBdE52gtDsCvyGPF8tnpiBFGxrhkj+XmNHP3HPwt3fYAdD5LaZmMledxUztdMRAjQ6X1L+C++Luw3YvKHRFg7LiMfyXbDPQ2Q2gbfmxBn+Yym2gi3MPTV3nSDRhuMqA/pQnbjCH6N7TzuwWOLIIKig5vSB88aE8BK/5ltblIEYJpZXqQqaINgGGGqc9rWtKNY3U4G4C8VwQcoxJgnnU7YBIO6yqTm15bfNfA7fiQ1eL0KEOaCS8XTPxgo5rnOK3v1uCdJECm14baXkgjJjE4FTwbL2JQ1D94c9pjJJr3k4Ij81K0ljEbBB7PekfAes6rBgTw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(376002)(396003)(346002)(46966006)(40470700004)(36840700001)(8936002)(9786002)(336012)(82310400005)(44832011)(186003)(26005)(5660300002)(41300700001)(426003)(53546011)(31696002)(40460700003)(356005)(2616005)(7636003)(47076005)(82740400003)(2906002)(54906003)(83380400001)(36860700001)(40480700001)(70586007)(316002)(110136005)(70206006)(4326008)(478600001)(36756003)(8676002)(31686004)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 16:24:44.4358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4e90e01-05c8-41da-7b42-08da91b6a3f7 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0056.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4761 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/8/2022 9:44 AM, Chaoyong He wrote: > The NFP card can load different firmware applications. Currently > only the CoreNIC application is supported. This commit makes > needed infrastructure changes in order to support other firmware > applications too. > > Clearer separation is made between the PF device and any application > specific concepts. The PF struct is now generic regardless of the > application loaded. A new struct is also made for the CoreNIC > application. Future additions to support other applications should > also add an applications specific struct. > What do you think to replace 'application' usage in the commit log with 'application firmware'? <...> > diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c > index e9d01f4..bd9cf67 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -39,15 +39,15 @@ > #include "nfp_cpp_bridge.h" > > static int > -nfp_net_pf_read_mac(struct nfp_pf_dev *pf_dev, int port) > +nfp_net_pf_read_mac(struct nfp_app_fw_nic *app_hw_nic, int port) Is this intentional that struct name is 'nfp_app_fw_nic' but variable name is 'app_hw_nic'? Why is app_fw vs app_hw difference? <...> > @@ -890,27 +937,12 @@ > } > > /* Populate the newly created PF device */ > + pf_dev->app_fw_id = app_hw_id; ditto.