From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id 35D4DB560 for ; Thu, 19 Feb 2015 12:18:23 +0100 (CET) Received: by wesw62 with SMTP id w62so6586769wes.9 for ; Thu, 19 Feb 2015 03:18:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=aHJBciKks1Tywb1GA27huRYpl19rVMRep4chDi0Yru0=; b=O04/HO9Va1BfUrS9Ej0N+kZojMAssebHI/pZTK3Y2BjMU6czMngabvOEa+Xd6VGfsd Dfi070KJX7dtk5HzoWaaSBA/Zrg3Xnzw0E9I7uzhKh7+Gf4l6QU1cuJ3EvoOXskK4Xts N5bQ1Ebockhcs61BZjDUlPJk1ka9I4iF8n61iXiKidsmqv+gOTHtMupFFmFjUULe9fuZ Cxsurh1fAQL3D/aqrfWoiItvvcp17V4ZDXwshDHkKsHDITpVQeGE77SMj44ikzquNfoS 1bYk0bBUPTlcDyXie7woe58byhD+PESFVybv0s3J4aPOlbo2kb31ic9Ck0VrOnVUHPhR isbA== X-Gm-Message-State: ALoCoQnaB8i9th9shk2UGzVmJJBjcxOB+B5GcJYsgvN2tYCXX63ObY/hU/na4wvsXdWHQCVlIWjC X-Received: by 10.194.158.234 with SMTP id wx10mr8209469wjb.23.1424344702941; Thu, 19 Feb 2015 03:18:22 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u6sm32036849wix.12.2015.02.19.03.18.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Feb 2015 03:18:22 -0800 (PST) From: Thomas Monjalon To: Tetsuya Mukawa Date: Thu, 19 Feb 2015 12:17:53 +0100 Message-ID: <5677937.pUHUTuZF0f@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1424314187-25177-3-git-send-email-mukawa@igel.co.jp> References: <1424060073-23484-12-git-send-email-mukawa@igel.co.jp> <1424314187-25177-1-git-send-email-mukawa@igel.co.jp> <1424314187-25177-3-git-send-email-mukawa@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 11:18:23 -0000 > @@ -152,6 +159,7 @@ struct rte_pci_device { > uint16_t max_vfs; /**< sriov enable if not zero */ > int numa_node; /**< NUMA node connection */ > struct rte_devargs *devargs; /**< Device user arguments */ > + enum rte_pt_driver pt_driver; /**< Driver of passthrough */ [...] > +static int > +pci_get_kernel_driver_by_path(const char *filename, char *dri_name) I think "kernel driver" is a good name. Why not using this name in the pci_device struct to be more consistent? Thanks