From: Olivier MATZ <olivier.matz@6wind.com>
To: "Hanoch Haim (hhaim)" <hhaim@cisco.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Ido Barnea \(ibarnea\)" <ibarnea@cisco.com>,
"Itay Marom \(imarom\)" <imarom@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update
Date: Tue, 05 Jan 2016 13:12:35 +0100 [thread overview]
Message-ID: <568BB333.9090707@6wind.com> (raw)
In-Reply-To: <521c3b8c6a014c24824bb1c5f17dca03@XCH-RTP-017.cisco.com>
Hi Hanoch,
On 01/05/2016 12:11 PM, Hanoch Haim (hhaim) wrote:
> Hi Oliver,
> Thank you for the fast response and it would be great to open a discussion on that.
> In general our project can leverage your optimization and I think it is great (we should have thought about it) . We can use it using the workaround I described.
> However, for me it seems odd that rte_pktmbuf_attach () that does not *change* anything in m_const, except of the *atomic* ref counter does not work in parallel.
> The example I gave is a classic use case of rte_pktmbuf_attach (multicast ) and I don't see why it wouldn't work after your optimization.
>
> Do you have a pointer to the documentation that state that that you can't call the atomic ref counter from more than one thread?
Unfortunately it's not documented yet, but it's something we should
better describe.
Regards,
Olivier
next prev parent reply other threads:[~2016-01-05 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 9:39 Hanoch Haim (hhaim)
2016-01-04 13:53 ` Olivier MATZ
2016-01-04 14:43 ` Hanoch Haim (hhaim)
2016-01-05 10:57 ` Olivier MATZ
2016-01-05 11:11 ` Hanoch Haim (hhaim)
2016-01-05 12:12 ` Olivier MATZ [this message]
2016-01-13 11:48 ` Bruce Richardson
2016-01-13 16:28 ` Hanoch Haim (hhaim)
2016-01-13 16:40 ` Bruce Richardson
-- strict thread matches above, loose matches on Subject: below --
2015-06-01 9:32 [dpdk-dev] [PATCH] mbuf: optimize first reference increment in rte_pktmbuf_attach Olivier Matz
2015-06-08 14:57 ` [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update Olivier Matz
2015-06-09 12:57 ` Bruce Richardson
2015-06-12 14:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568BB333.9090707@6wind.com \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hhaim@cisco.com \
--cc=ibarnea@cisco.com \
--cc=imarom@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).