From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 12477935C for ; Tue, 5 Jan 2016 13:12:54 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id f206so20651520wmf.0 for ; Tue, 05 Jan 2016 04:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Dlxnw8JWjnR0cYixuLTcZmirBg/Hlh2Rb+tjb01rZy4=; b=u4cXnPxhoICMhH1LvHl+IWtNl/eHcNE6rutiFC7A0CFkcKJNJXXOwwYy6+AFebhjWs g/K97FyLTSm995XQWzZ1bXnhPSmOoZBeecPb+eNZWXZIEGvTRkDeOBVMCKWp/mgOgTaz R+s7RBqFuswFS5unkbPT7arora0+79UtqoitlR6HMNBZtBtNFpBTM6H2FuYPsV3i1Mb/ tL+utwThoBBFg8PRvz82MzUJG2icpACKimS1LSCrWEYFWS9Bq1cWwZcnrVYxt4JP3E6D qhW8I9K5MzCj6s4x55O+sNBdWviEictMR+pP9fAECl6P6aXY80CjoZxYzPSIlxxe8vDY HGaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Dlxnw8JWjnR0cYixuLTcZmirBg/Hlh2Rb+tjb01rZy4=; b=JTGfkeA1hC5FW8PknvIX139D+FHNM8+FX1bLoI6MmpXq3qQz2mnMJvd+eOCsHRXd53 YyIbg4CeLEuFhGc33MJEfsrxhU+Q3D+K0ZJ9QffMQQl7fEPQLx/mjPL0G4aaIUayu5nT GK4yUeN2+MJ0eJFRlcRn5lHpHYxQZGIcdgeiHS7hJ5ie5f+FukvHr+AJLg0nfso3U3N7 rTAiYBC0jA4r597ym5Lwi/wib1ucVE+dLDcTC9LZD7EcU59FetYO5K/4wbPRjAqUZDPt GhvtST7rizj3QEjcZI8dJkCIEYoR8JV8JD9Ae97LEFHWA3rPalBsDi6dRL95P+5ugmpq uqWw== X-Gm-Message-State: ALoCoQnJjAAxIDHehM6Be5FPSor4EamYXKW72Q4gapQdMwtkaoTF9FGYoGE/F5XOxDeO5WRlIv4qFmTafbU4X9UYMxrHySALWw== X-Received: by 10.28.55.76 with SMTP id e73mr3953797wma.53.1451995973858; Tue, 05 Jan 2016 04:12:53 -0800 (PST) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id av8sm15899510wjc.13.2016.01.05.04.12.52 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Jan 2016 04:12:52 -0800 (PST) Message-ID: <568BB333.9090707@6wind.com> Date: Tue, 05 Jan 2016 13:12:35 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Hanoch Haim (hhaim)" , "bruce.richardson@intel.com" References: <568A7959.7030506@6wind.com> <7f5255b98dcb4f2396ada16d5eb43e5a@XCH-RTP-017.cisco.com> <568BA1A1.2070300@6wind.com> <521c3b8c6a014c24824bb1c5f17dca03@XCH-RTP-017.cisco.com> In-Reply-To: <521c3b8c6a014c24824bb1c5f17dca03@XCH-RTP-017.cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Ido Barnea \(ibarnea\)" , "Itay Marom \(imarom\)" Subject: Re: [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 12:12:54 -0000 Hi Hanoch, On 01/05/2016 12:11 PM, Hanoch Haim (hhaim) wrote: > Hi Oliver, > Thank you for the fast response and it would be great to open a discussion on that. > In general our project can leverage your optimization and I think it is great (we should have thought about it) . We can use it using the workaround I described. > However, for me it seems odd that rte_pktmbuf_attach () that does not *change* anything in m_const, except of the *atomic* ref counter does not work in parallel. > The example I gave is a classic use case of rte_pktmbuf_attach (multicast ) and I don't see why it wouldn't work after your optimization. > > Do you have a pointer to the documentation that state that that you can't call the atomic ref counter from more than one thread? Unfortunately it's not documented yet, but it's something we should better describe. Regards, Olivier