From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D63E39390 for ; Tue, 5 Jan 2016 14:48:19 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 05 Jan 2016 05:48:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,525,1444719600"; d="scan'208";a="853903716" Received: from dwdohert-dpdk.ir.intel.com ([163.33.213.167]) by orsmga001.jf.intel.com with ESMTP; 05 Jan 2016 05:48:17 -0800 To: Stephen Hemminger References: <1449249260-15165-1-git-send-email-stephen@networkplumber.org> <1449249260-15165-9-git-send-email-stephen@networkplumber.org> From: Declan Doherty Message-ID: <568BC96A.5090004@intel.com> Date: Tue, 5 Jan 2016 13:47:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449249260-15165-9-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Eric Kinzie Subject: Re: [dpdk-dev] [PATCH 8/8] bond: do not activate slave twice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 13:48:20 -0000 On 04/12/15 17:14, Stephen Hemminger wrote: > From: Eric Kinzie > > The current code for detecting link during slave addition can cause a > slave interface to be activated twice -- once during slave_configure() > and again at the end of __eth_bond_slave_add_lock_free(). This will > either cause the active slave count to be incorrect or will cause the > 802.3ad activation function to panic. Ensure that the interface is not > activated more than once. > > Signed-off-by: Eric Kinzie > Signed-off-by: Stephen Hemminger > --- ... > Acked-by: Declan Doherty