From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Pavel Fedin <p.fedin@samsung.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC 0/5] virtio support for container
Date: Wed, 6 Jan 2016 13:47:28 +0800 [thread overview]
Message-ID: <568CAA70.7070201@intel.com> (raw)
In-Reply-To: <000301d143e1$6c5c0e90$45142bb0$@samsung.com>
On 12/31/2015 11:39 PM, Pavel Fedin wrote:
> Hello!
>
> Last minute note. I have found the problem but have no time to research and fix it.
> It happens because ovs first creates the device, starts it, then stops it, and reconfigures queues. The second queue allocation
> happens from within netdev_set_multiq(). Then ovs restarts the device and proceeds to actually using it.
> But, queues are not initialized properly in DPDK after the second allocation. Because of this thing:
>
> /* On restart after stop do not touch queues */
> if (hw->started)
> return 0;
Hi Fedin,
As you see, I also think it is a bug. A device should be ok to
start/stop/start...
I already send a patch to fix this.
http://dpdk.org/ml/archives/dev/2016-January/031010.html
Thanks,
Jianfeng
>
> It keeps us away from calling virtio_dev_rxtx_start(), which should in turn call virtio_dev_vring_start(), which calls
> vring_init(). So, VIRTQUEUE_NUSED() dies badly because vq->vq_ring all contains NULLs.
> See you all after 10th. And happy New Year again!
>
>
next prev parent reply other threads:[~2016-01-06 5:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 9:46 Pavel Fedin
2015-12-31 9:19 ` Tan, Jianfeng
2015-12-31 9:40 ` Pavel Fedin
2015-12-31 10:02 ` Tan, Jianfeng
2015-12-31 10:38 ` Pavel Fedin
2015-12-31 11:58 ` Tan, Jianfeng
2015-12-31 12:44 ` Pavel Fedin
2015-12-31 12:54 ` Tan, Jianfeng
2015-12-31 13:07 ` Pavel Fedin
2015-12-31 13:47 ` Pavel Fedin
2015-12-31 15:39 ` Pavel Fedin
2016-01-06 5:47 ` Tan, Jianfeng [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-15 8:21 Avi Cohen (A)
2015-11-05 18:31 Jianfeng Tan
2015-11-24 3:53 ` Zhuangyanying
2015-11-24 6:19 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568CAA70.7070201@intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=p.fedin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).