From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0EE399430 for ; Wed, 6 Jan 2016 09:23:19 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 06 Jan 2016 00:23:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,528,1444719600"; d="scan'208";a="875506091" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.119]) ([10.239.67.119]) by fmsmga001.fm.intel.com with ESMTP; 06 Jan 2016 00:23:17 -0800 To: Rahul Lakkireddy References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1451544799-70776-3-git-send-email-jianfeng.tan@intel.com> <20160106071112.GA3690@scalar.blr.asicdesigners.com> From: "Tan, Jianfeng" Message-ID: <568CCEF4.4070202@intel.com> Date: Wed, 6 Jan 2016 16:23:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160106071112.GA3690@scalar.blr.asicdesigners.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Kumar Sanghvi , Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH 02/12] pmd/cxgbe: add dev_ptype_info_get implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2016 08:23:20 -0000 On 1/6/2016 3:11 PM, Rahul Lakkireddy wrote: > Hi Jianfeng, > > On Thursday, December 12/31/15, 2015 at 14:53:09 +0800, Jianfeng Tan wrote: >> Signed-off-by: Jianfeng Tan >> --- >> drivers/net/cxgbe/cxgbe_ethdev.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c >> index 97ef152..f17d5d5 100644 >> --- a/drivers/net/cxgbe/cxgbe_ethdev.c >> +++ b/drivers/net/cxgbe/cxgbe_ethdev.c >> @@ -767,6 +767,22 @@ static int cxgbe_flow_ctrl_set(struct rte_eth_dev *eth_dev, >> &pi->link_cfg); >> } >> >> +static int cxgbe_dev_ptype_info_get(struct rte_eth_dev *eth_dev __rte_unused, >> + uint32_t ptype_mask, uint32_t ptypes[]) >> +{ > No need for the __rte_unused for eth_dev above since it's being used for > if conditional below. Hi Rahul, Thanks! Will fix it in next version. Jianfeng