From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 843A79580 for ; Thu, 7 Jan 2016 10:33:58 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 07 Jan 2016 01:33:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,532,1444719600"; d="scan'208";a="25050166" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.54]) ([10.237.220.54]) by fmsmga004.fm.intel.com with ESMTP; 07 Jan 2016 01:33:56 -0800 From: Sergio Gonzalez Monroy To: Ralf Hoffmann References: <55EEEF99.2000708@intel.com> <1451986625-16645-1-git-send-email-ralf.hoffmann@allegro-packets.com> <1451986625-16645-2-git-send-email-ralf.hoffmann@allegro-packets.com> Message-ID: <568E3103.9060707@intel.com> Date: Thu, 7 Jan 2016 09:33:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1451986625-16645-2-git-send-email-ralf.hoffmann@allegro-packets.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/1] eal/linux: change hugepage sorting to avoid overlapping memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2016 09:33:58 -0000 On 05/01/2016 09:37, Ralf Hoffmann wrote: > with only one hugepage or already sorted hugepage addresses, the sort > function called memcpy with same src and dst pointer. Debugging with > valgrind will issue a warning about overlapping area. This patch > changes the sort method to qsort to avoid this behavior, according to > original patch from Jay Rolette . The separate > sort function is no longer necessary. > > Signed-off-by: Ralf Hoffmann > --- > Acked-by: Sergio Gonzalez Monroy