From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de [80.67.31.35]) by dpdk.org (Postfix) with ESMTP id 3BB859430 for ; Thu, 7 Jan 2016 14:58:59 +0100 (CET) Received: from [87.172.132.35] (helo=[10.54.0.105]) by smtprelay01.ispgateway.de with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.84) (envelope-from ) id 1aHB5e-0004Pa-Ah; Thu, 07 Jan 2016 14:58:58 +0100 To: Sergio Gonzalez Monroy References: <55EEEF99.2000708@intel.com> <1451986625-16645-1-git-send-email-ralf.hoffmann@allegro-packets.com> <1451986625-16645-2-git-send-email-ralf.hoffmann@allegro-packets.com> <568E3103.9060707@intel.com> <568E3527.2080302@intel.com> <568E403B.7040002@intel.com> From: Ralf Hoffmann X-Enigmail-Draft-Status: N1110 Message-ID: <568E6F21.1060408@allegro-packets.com> Date: Thu, 7 Jan 2016 14:58:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <568E403B.7040002@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Df-Sender: cmFsZi5ob2ZmbWFubkBhbGxlZ3JvLXBhY2tldHMuY29t Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/1] eal/linux: change hugepage sorting to avoid overlapping memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2016 13:58:59 -0000 Hi Sergio, On 07.01.2016 11:38, Sergio Gonzalez Monroy wrote: >> Forgot to mention that there is a checkpatch warning: >> WARNING:LONG_LINE: line over 90 characters >> #113: FILE: lib/librte_eal/linuxapp/eal/eal_memory.c:1167: >> + qsort(&tmp_hp[hp_offset], hpi->num_pages[0], >> sizeof(struct hugepage_file), cmp_physaddr); >> >> Could you fix that Ralf? >> >> Thanks, >> Sergio > > Just FYI, there is a new DPDK Contributors guide: > http://dpdk.org/doc/guides/contributing/patches.html I will send an updated patch right away, fixing that warning. I was aware of that guide, it's really good. Interestingly I have already used the checkpatches.sh script as described on that page, but it just said "1/1 valid patch" so I assumed it was ok. But indeed, running the checkpath.pl manually showed that line size warning, thanks for the hint. The checkpatches.sh only checks the return code, so it does not see the warning. Best Regards, Ralf