From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Ralf Hoffmann <ralf.hoffmann@allegro-packets.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/1] change hugepage sorting to avoid overlapping memcpy
Date: Thu, 7 Jan 2016 14:36:35 +0000 [thread overview]
Message-ID: <568E77F3.8070408@intel.com> (raw)
In-Reply-To: <1452175142-17790-1-git-send-email-ralf.hoffmann@allegro-packets.com>
Hi Ralf,
It seems like the title update you did for v3 is missing in this patch.
On 07/01/2016 13:59, Ralf Hoffmann wrote:
> with only one hugepage or already sorted hugepage addresses, the sort
> function called memcpy with same src and dst pointer. Debugging with
> valgrind will issue a warning about overlapping area. This patch changes
> the sort method to qsort to avoid this behavior. The separate sort
> function is no longer necessary.
>
> Signed-off-by: Ralf Hoffmann <ralf.hoffmann@allegro-packets.com>
> ---
>
Once you fix that you can add my Acked-by to your commit message.
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
By the way, just a reminder to update the status of previous patches in
patchwork as 'superseded'.
Regards,
Sergio
next prev parent reply other threads:[~2016-01-07 14:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 10:14 [dpdk-dev] [PATCH v1] " Ralf Hoffmann
2015-09-08 12:45 ` Gonzalez Monroy, Sergio
2015-09-08 13:29 ` Jay Rolette
2015-09-08 14:24 ` Gonzalez Monroy, Sergio
2016-01-05 9:25 ` [dpdk-dev] [PATCH v2 0/1] " Ralf Hoffmann
2016-01-05 9:25 ` [dpdk-dev] [PATCH v2 1/1] " Ralf Hoffmann
2016-01-05 9:37 ` [dpdk-dev] [PATCH v3 0/1] eal/linux: " Ralf Hoffmann
2016-01-05 9:37 ` [dpdk-dev] [PATCH v3 1/1] " Ralf Hoffmann
2016-01-07 9:33 ` Sergio Gonzalez Monroy
2016-01-07 9:51 ` Sergio Gonzalez Monroy
2016-01-07 10:38 ` Sergio Gonzalez Monroy
2016-01-07 13:58 ` Ralf Hoffmann
2016-01-07 13:59 ` [dpdk-dev] [PATCH v4 1/1] " Ralf Hoffmann
2016-01-07 14:36 ` Sergio Gonzalez Monroy [this message]
2016-01-07 14:54 ` [dpdk-dev] [PATCH v5 1/1] eal/linux: " Ralf Hoffmann
2016-03-02 16:13 ` Thomas Monjalon
2015-09-09 8:41 ` [dpdk-dev] [PATCH v1] " Ralf Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E77F3.8070408@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=ralf.hoffmann@allegro-packets.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).