From: Vipul Ashri <vipul.ashri@oracle.com> To: javin158@163.com Cc: yong.liu@intel.com, chenbo.xia@intel.com, dev@dpdk.org Subject: [dpdk-dev] FW: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions") Date: Thu, 13 Aug 2020 07:23:01 +0000 (UTC) Message-ID: <5691bd22-32dd-46cc-8a1c-1bced4183015@default> (raw) In-Reply-To: <MN2PR11MB40631D2BC5427696D1BA1A919C420@MN2PR11MB4063.namprd11.prod.outlook.com> Hi Javin FYI http://patches.dpdk.org/patch/75476/ The mentioned fix you are trying to submit is already addressed and in review with Xia chenbo since 10th august. Hope you can discard your patch as I have already sent the patch to dpdk community. Regards Vipul -----Original Message----- From: Xia, Chenbo [mailto:chenbo.xia@intel.com] Sent: Wednesday, 12 August, 2020 17:31 To: Vipul Ashri <vipul.ashri@oracle.com>; dev@dpdk.org Cc: Edwin Leung <edwin.leung@oracle.com> Subject: RE: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions") Hi Vipul, > -----Original Message----- > From: Vipul Ashri <vipul.ashri@oracle.com> > Sent: Wednesday, August 12, 2020 5:23 PM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo.xia@intel.com>; vipul.ashri@oracle.com; > edwin.leung@oracle.com > Subject: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring > functions") > > Problem - Standard Tx packets are not going out and found broken due > to cleanup malfunctioning whereever below mentioned macro is used. > > RootCause - Here inside Macro 'ASSIGN_UNLESS_EQUAL(var, val)' > assignment to 'var' argument passed is always failing as assignment > done using 'var_' having local scope only. > > Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com> I understand now. Your patch makes sense. But your commit title/msg is still wrong. An example commit message should be (you could use this): net/virtio: fix wrong variable assignment in helper macro Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment. Fixes: 57f90f894588("net/virtio: reuse packed ring functions") Cc: stable@dpdk.org Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com> > --- > drivers/net/virtio/virtqueue.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/virtio/virtqueue.h > b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) > > /* avoid write operation when necessary, to lessen cache issues */ > #define ASSIGN_UNLESS_EQUAL(var, val) do { \ > - typeof(var) var_ = (var); \ > - typeof(val) val_ = (val); \ > - if ((var_) != (val_)) \ > - (var_) = (val_); \ > + if ((var) != (val)) \ > + (var) = (val); \ > } while (0) > > #define virtqueue_clear_net_hdr(hdr) do { \ > -- > 2.28.0.windows.1
next prev parent reply other threads:[~2020-08-18 13:49 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-07 12:57 [dpdk-dev] [PATCH] Virtio TX: reverting a small change causing Virtio standard TX broken Vipul Ashri 2020-08-09 13:28 ` Vipul Ashri 2020-08-10 4:10 ` Xia, Chenbo 2020-08-10 19:59 ` [dpdk-dev] [PATCH v2] net/virtio: fix 57f90f8("net/virtio: reuse packed ring functions") Vipul Ashri 2020-08-11 1:39 ` Xia, Chenbo 2020-08-12 9:23 ` [dpdk-dev] [PATCH v2] Fixes: 57f90f894588("net/virtio: " Vipul Ashri 2020-08-12 12:00 ` Xia, Chenbo 2020-08-13 7:23 ` Vipul Ashri [this message] 2020-08-13 7:27 ` [dpdk-dev] FW: " chupenghong 2020-08-13 7:25 ` [dpdk-dev] [PATCH v2] net/virtio: fix wrong variable assignment in helper macro Vipul Ashri 2020-08-13 7:28 ` [dpdk-dev] [PATCH v3] " Vipul Ashri 2020-08-13 7:35 ` Xia, Chenbo 2020-08-19 1:25 ` Xia, Chenbo 2020-09-16 5:57 ` [dpdk-dev] [PATCH v4] " Vipul Ashri 2020-09-17 15:54 ` Andrew Rybchenko 2020-09-18 9:55 ` [dpdk-dev] [PATCH v5] " Vipul Ashri 2020-09-18 12:22 ` Maxime Coquelin 2020-09-18 12:30 ` Maxime Coquelin 2020-08-13 16:22 ` [dpdk-dev] [PATCH v3] " Vipul Ashri 2020-08-14 1:25 ` Xia, Chenbo 2020-08-14 5:23 ` Vipul Ashri 2020-08-18 18:45 ` Ferruh Yigit 2020-08-18 20:46 ` Vipul Ashri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5691bd22-32dd-46cc-8a1c-1bced4183015@default \ --to=vipul.ashri@oracle.com \ --cc=chenbo.xia@intel.com \ --cc=dev@dpdk.org \ --cc=javin158@163.com \ --cc=yong.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git