From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2AF7A0521; Tue, 3 Nov 2020 13:52:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02DAFCA2A; Tue, 3 Nov 2020 13:52:33 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C62D2CA26 for ; Tue, 3 Nov 2020 13:52:30 +0100 (CET) IronPort-SDR: zrz8rtaDItHu2OL2+2UZ8Pqmxmwpfj+3E54nzGLzIbipkylG9nP37vzFCSds6yf35BU42j/Zia r2yK++z1gTMA== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="156034575" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="156034575" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 04:52:28 -0800 IronPort-SDR: TEaYFPo/I/WxfFPUT4rvfS5OF2gM+eTQQHEPdV5AWS9ose3Ijk8FjJoi2JMDYWtq8drzyNZ4UM /mw44ZbjlUHA== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538481125" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 04:52:27 -0800 To: Andrew Boyer , dev@dpdk.org Cc: cardigliano@ntop.org References: <20201102183527.69209-1-aboyer@pensando.io> <20201102183527.69209-8-aboyer@pensando.io> From: Ferruh Yigit Message-ID: <5691f272-1d26-4108-dc0a-25d158e392d5@intel.com> Date: Tue, 3 Nov 2020 12:52:24 +0000 MIME-Version: 1.0 In-Reply-To: <20201102183527.69209-8-aboyer@pensando.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 7/8] ionic: warn if RTE tries to enable loopback mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 6:35 PM, Andrew Boyer wrote: > The ionic FW does not support loopback mode at this time. > "RTE tries to enable"? what about, net/ionic: warn if loopback mode is requested > Signed-off-by: Andrew Boyer > --- > drivers/net/ionic/ionic_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c > index 600333e20..ff5c2e51a 100644 > --- a/drivers/net/ionic/ionic_ethdev.c > +++ b/drivers/net/ionic/ionic_ethdev.c > @@ -919,6 +919,9 @@ ionic_dev_start(struct rte_eth_dev *eth_dev) > return -EINVAL; > } > > + if (dev_conf->lpbk_mode) > + IONIC_PRINT(WARNING, "Loopback mode not supported"); > + > err = ionic_lif_start(lif); > if (err) { > IONIC_PRINT(ERR, "Cannot start LIF: %d", err); >