From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 07CF5567A for ; Tue, 12 Jan 2016 07:01:06 +0100 (CET) Received: by mail-pf0-f173.google.com with SMTP id n128so57186903pfn.3 for ; Mon, 11 Jan 2016 22:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=+pqgstSSBPbQcsdyXm2KkRUGha7svvUjwKsFq1f6Pn4=; b=0y3bfbhFKB8SImCQKju3Ik9xsCw8xB1u5RjG/vpue5Df2GRRJF2GTFZ7+aAyFipP1n o5IrFCoAZdSm3vdQCHUF4/XWmKgPCW4ZYomNHrvqpohcil6ec88K28dX8ZhKDUqXsLEE VKKFa2ar6Pe/ljgldEjxhjnNbUGorb6mPj7YM7ahRq5LJ+rIBCKGxI/KNv3ZiuyH9U0S prndIeJbWYjzyUFKQ+tg9bjHdJda8yXdoSqrqsLq7Pum4bTOsuyMDs09sQ/j/viXiV8W IQPoVJCvIBNBqV1zPlgeZYkR6R2/lsx25En+MMKiQdu7nj8NSo3Bxwjldzao9FH1WRRb r2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=+pqgstSSBPbQcsdyXm2KkRUGha7svvUjwKsFq1f6Pn4=; b=WYal+l1NyTXQewIqzZuYwoOcYX403Yo5LVxtxHVXKmn7um5T8BrGWa/UiP3f7S5stZ tCEjSq2PVI1s9FtuUdAN/Berc2OEDuSSZUCFQlpOdAd2gwFuuEON1IKrKBJ8hVotd7DM BfBjjTRkxfYuVs+6IQ9xW5c+9WNCD/RhnD2w+mt6UVAeNkB4p9XONG+2fsDZOqpil6P8 Y8Vl6p1jgiOIJdTIyuKxAaY95K7hA7o6AuJHwO7OILZnPYVuPfkOu/kFpG8xCyXoZHY5 uiJJ912I5I6iVYvcQbyZkgHP3uA1fMrF7kRdXM9/ntuqTKFv/SBK2x0sMF3GyUfMpVpx Sx4A== X-Gm-Message-State: ALoCoQk19UGdfACHr58hOhiFO5kMVxdwPO5yjjTYQ2yxtqixdALxbtcTFwnMEkLivrqUDFiNswyyVIoY0MgPe6gh7K5x784ofg== X-Received: by 10.98.70.17 with SMTP id t17mr31383746pfa.107.1452578465357; Mon, 11 Jan 2016 22:01:05 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id o67sm27210478pfa.58.2016.01.11.22.01.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Jan 2016 22:01:04 -0800 (PST) To: "Tan, Jianfeng" , dev@dpdk.org, huawei.xie@intel.com References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <1452426182-86851-1-git-send-email-jianfeng.tan@intel.com> <569490D9.10803@igel.co.jp> <5694934B.5070900@intel.com> From: Tetsuya Mukawa Message-ID: <5694969D.3040008@igel.co.jp> Date: Tue, 12 Jan 2016 15:01:01 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5694934B.5070900@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: nakajima.yoshihiro@lab.ntt.co.jp, mst@redhat.com, ann.zhuangyanying@huawei.com Subject: Re: [dpdk-dev] [PATCH 0/4] virtio support for container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 06:01:06 -0000 On 2016/01/12 14:46, Tan, Jianfeng wrote: > > Hi Tetsuya, > > >> Hi Jianfeng and Xie, >> >> I guess my implementation and yours have a lot of common code, so I will >> try to rebase my patch on yours. > > We also think so. And before you rebase your code, I think we can rely > on Yuanhan's > struct virtio_pci_ops to make the code structure brief and clear, as > discussed in your > patch's thread, i.e., we both rebase our code according to Yuanhan's > code. Is that OK? > Yes, I agree with it. Thanks, Tetsuya > >> >> BTW, one thing I need to change your memory allocation way is that >> mmaped address should be under 44bit(32 + PAGE_SHIFT) to work with my >> patch. >> This is because VIRTIO_PCI_QUEUE_PFN register only accepts such address. >> (I may need to add one more EAL parameter like "--mmap-under
") > > It makes sense. > > Thanks, > Jianfeng > >> >> Thanks, >> Tetsuya >