From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1A9D48E5D for ; Tue, 12 Jan 2016 13:46:11 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DACEF7D; Tue, 12 Jan 2016 12:46:09 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-61.ams2.redhat.com [10.36.7.61]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0CCk8c6021721; Tue, 12 Jan 2016 07:46:08 -0500 To: Nelio Laranjeiro , dev@dpdk.org References: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com> <1452595749-11297-1-git-send-email-nelio.laranjeiro@6wind.com> <1452595749-11297-2-git-send-email-nelio.laranjeiro@6wind.com> From: Panu Matilainen Message-ID: <5694F58F.1040105@redhat.com> Date: Tue, 12 Jan 2016 14:46:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1452595749-11297-2-git-send-email-nelio.laranjeiro@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH v2 1/3] cmdline: increase command line buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 12:46:11 -0000 On 01/12/2016 12:49 PM, Nelio Laranjeiro wrote: > Allow long command lines in testpmd (like flow director with IPv6, ...). > > Signed-off-by: John McNamara > Signed-off-by: Nelio Laranjeiro > --- > doc/guides/rel_notes/deprecation.rst | 5 ----- > lib/librte_cmdline/cmdline_rdline.h | 2 +- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index e94d4a2..9cb288c 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -44,8 +44,3 @@ Deprecation Notices > and table action handlers will be updated: > the pipeline parameter will be added, the packets mask parameter will be > either removed (for input port action handler) or made input-only. > - > -* ABI changes are planned in cmdline buffer size to allow the use of long > - commands (such as RETA update in testpmd). This should impact > - CMDLINE_PARSE_RESULT_BUFSIZE, STR_TOKEN_SIZE and RDLINE_BUF_SIZE. > - It should be integrated in release 2.3. > diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/cmdline_rdline.h > index b9aad9b..72e2dad 100644 > --- a/lib/librte_cmdline/cmdline_rdline.h > +++ b/lib/librte_cmdline/cmdline_rdline.h > @@ -93,7 +93,7 @@ extern "C" { > #endif > > /* configuration */ > -#define RDLINE_BUF_SIZE 256 > +#define RDLINE_BUF_SIZE 512 > #define RDLINE_PROMPT_SIZE 32 > #define RDLINE_VT100_BUF_SIZE 8 > #define RDLINE_HISTORY_BUF_SIZE BUFSIZ Having to break a library ABI for a change like this is a bit ridiculous. I didn't try it so could be wrong, but based on a quick look, struct rdline could easily be made opaque to consumers by just adding functions for allocating and freeing it. - Panu -