From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D21CAA0C3F; Mon, 28 Jun 2021 14:23:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F49140692; Mon, 28 Jun 2021 14:23:52 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 541A94068A for ; Mon, 28 Jun 2021 14:23:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10028"; a="204935104" X-IronPort-AV: E=Sophos;i="5.83,306,1616482800"; d="scan'208";a="204935104" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 05:23:46 -0700 X-IronPort-AV: E=Sophos;i="5.83,306,1616482800"; d="scan'208";a="446546365" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.205.12]) ([10.213.205.12]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 05:23:44 -0700 To: Igor Ryzhov Cc: "Kinsella, Ray" , Thomas Monjalon , Stephen Hemminger , dpdk-dev References: <7ecdea57-f87e-6a1e-e52d-422a925046e4@ashroe.eu> From: Ferruh Yigit X-User: ferruhy Message-ID: <56991784-7289-b03b-2dbf-f2a42367368a@intel.com> Date: Mon, 28 Jun 2021 13:23:40 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] Experimental symbols in kni lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/25/2021 2:26 PM, Igor Ryzhov wrote: > Hi Ferruh, all, > > Let's please discuss another approach to setting KNI link status before > making this API stable: > http://patches.dpdk.org/project/dpdk/patch/20190925093623.18419-1-iryzhov@nfware.com/ > > I explained the problem with the current implementation there. > More than that, using ioctl approach makes it possible to set also speed > and duplex and use them to implement get_link_ksettings callback. > I can send patches for both features. > Hi Igor, agree to discuss your patch before promoting the API, I will comment on the outstanding patch. > Igor > > On Thu, Jun 24, 2021 at 4:54 PM Kinsella, Ray wrote: > >> Sounds more than reasonable, +1 from me. >> >> Ray K >> >> On 24/06/2021 14:24, Ferruh Yigit wrote: >>> On 6/24/2021 11:42 AM, Kinsella, Ray wrote: >>>> Hi Ferruh, >>>> >>>> The following kni experimental symbols are present in both v21.05 and >> v19.11 release. These symbols should be considered for promotion to stable >> as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= >> 2yrs at this point. >>>> >>>> * rte_kni_update_link >>>> >>>> Ray K >>>> >>> >>> Hi Ray, >>> >>> Thanks for follow up. >>> >>> I just checked the API and planning a small behavior update to it. >>> If the update is accepted, I suggest keeping the API experimental for >> 21.08 too, >>> but can mature it on v21.11. >>> >>> Thanks, >>> ferruh >>> >>