From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D427E9E3 for ; Tue, 20 Jun 2017 17:51:56 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2017 08:51:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,364,1493708400"; d="scan'208";a="1162645874" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.32]) ([10.237.221.32]) by fmsmga001.fm.intel.com with ESMTP; 20 Jun 2017 08:51:49 -0700 To: Jerin Jacob References: <1496736832-835-1-git-send-email-i.maximets@samsung.com> <2889333.ySLvsRWIRF@xps> <3955508.CKAFNdPa9c@xps> <7e71f1d8-f975-05ed-c14c-526c1c2c651f@intel.com> <20170620154138.GA8453@jerin> Cc: Thomas Monjalon , Ilya Maximets , dev@dpdk.org, Hemant Agrawal , Bruce Richardson , David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei From: Sergio Gonzalez Monroy Message-ID: <56997e9e-3eb4-5683-123a-393bb449dfb0@intel.com> Date: Tue, 20 Jun 2017 16:51:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20170620154138.GA8453@jerin> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 15:51:57 -0000 On 20/06/2017 16:41, Jerin Jacob wrote: > -----Original Message----- >> Date: Tue, 20 Jun 2017 15:58:50 +0100 >> From: Sergio Gonzalez Monroy >> To: Thomas Monjalon , Ilya Maximets >> >> CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson >> , David Marchand , >> Heetae Ahn , Yuanhan Liu , >> Jianfeng Tan , Neil Horman >> , Yulong Pei >> Subject: Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages >> User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 >> Thunderbird/45.1.1 >> >> On 20/06/2017 15:35, Thomas Monjalon wrote: >>> 20/06/2017 15:58, Ilya Maximets: >>>> On 20.06.2017 16:07, Thomas Monjalon wrote: >>>>> 19/06/2017 13:10, Hemant Agrawal: >>>>>>>>> On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: >>>>>>>>>> So, there are 2 option: >>>>>>>>>> >>>>>>>>>> 1. Return back config option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>>>>>>>> from the first version of the patch and disable it by default. >>>>>>>>>> >>>>>>>>>> 2. Keep patch as it is now and make everyone install libnuma >>>>>>>>>> for successful build. >>>>>> +1 for option 1 >>>>>> It will be a issue and undesired dependency for SoCs, not supporting >>>>>> NUMA architecture. >>>>>> >>>>>> It can be added to the config, who desired to use it by default. >>>>> Yes I agree, it cannot be a dependency for architectures which >>>>> do not support NUMA. >>>>> Please can we rework the patch so that only one node is assumed >>>>> if NUMA is disabled for the architecture? >> Ilya, I missed that libnuma is not supported on ARM. > It is supported on arm64 and arm64 has NUMA machines(thunderx, thunderx2) too. > > [dpdk.org] $ dpkg-query -L libnuma-dev > /. > /usr > /usr/lib > /usr/lib/aarch64-linux-gnu > /usr/lib/aarch64-linux-gnu/libnuma.a > /usr/share > /usr/share/man > /usr/share/man/man3 > /usr/share/man/man3/numa.3.gz > /usr/share/doc > /usr/share/doc/libnuma-dev > /usr/share/doc/libnuma-dev/copyright > /usr/include > /usr/include/numaif.h > /usr/include/numa.h > /usr/include/numacompat1.h > /usr/lib/aarch64-linux-gnu/libnuma.so > Is it ARMv7 then the only supported arch missing libnuma support? >>>> We're still don't have dynamic build time configuration system. >>>> To make get/set_mempolicy work we need to include >>>> and have libnuma for successful linkage. >>>> This means that the only option to not have libnuma as dependency >>>> is to return back configuration option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>> as it was in the first version of the patch. >>>> >>>> There is, actually, the third option (besides 2 already described): >>>> >>>> 3. Return back config option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES >>>> from the first version of the patch and *enable* it by default. >>>> In this case anyone who doesn't want to have libnuma as dependency >>>> will be able to disable the config option manually. >>>> >>>> Thomas, what do you think? Bruce? Sergio? >>> It should be enabled on x86 and ppc, and disabled in other >>> default configurations (ARM for now). >> Agree. >> >>>> P.S. We're always able to implement syscall wrappers by hands without any >>>> external dependencies, but I don't think it's a good decision. >>> I agree to use libnuma instead of re-inventing the wheel. >>> Let's just make it optional at build time and fallback on one node >>> if disabled. >> That is the simple way out. >> >> Sergio