Re: [dpdk-dev] [PATCH v5 1/2] tools: Add support for handling built-in kernel modules

[Kamil Rytarowski <krytarowski@caviumnetworks.com>]

Thank you, I will submit improved version as v6.

W dniu 18.01.2016 o 15:21, Yuanhan Liu pisze:
> Hi Kamil,
>
> First of all, sorry for no one has reviewed your patches for over one
> month! You may want to ping more often (say, per week) next time if it
> still happenes :)
>
> Another thing is that there is no maintainer for tools code.
>
> On Wed, Dec 09, 2015 at 02:19:57PM +0100, Kamil Rytarowski wrote:
>> Currently dpdk_nic_bind.py detects Linux kernel modules via reading
>> /proc/modules. Built-in ones aren't listed there and therefore they are not
>> being found by the script.
>>
>> Add support for checking built-in modules with parsing the sysfs files.
>>
>> This commit obsoletes the /proc/modules parsing approach.
>>
>> Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>
>> Signed-off-by: David Marchand <david.marchand@6wind.com>
>> ---
>>   tools/dpdk_nic_bind.py | 27 +++++++++++++++++----------
>>   1 file changed, 17 insertions(+), 10 deletions(-)
>>
>> diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
>> index f02454e..e161062 100755
>> --- a/tools/dpdk_nic_bind.py
>> +++ b/tools/dpdk_nic_bind.py
>> @@ -156,22 +156,29 @@ def check_modules():
>>       '''Checks that igb_uio is loaded'''
>>       global dpdk_drivers
>>   
>> -    fd = file("/proc/modules")
>> -    loaded_mods = fd.readlines()
>> -    fd.close()
>> -
>>       # list of supported modules
>>       mods =  [{"Name" : driver, "Found" : False} for driver in dpdk_drivers]
>>   
>>       # first check if module is loaded
>> -    for line in loaded_mods:
>> +    try:
>> +        # Get list of syfs modules, some of them might be builtin and merge with mods
>> +        sysfs_path = '/sys/module/'
>> +
>> +        # Get the list of directories in sysfs_path
>> +        sysfs_mods = [os.path.join(sysfs_path,o) for o in os.listdir(sysfs_path) if os.path.isdir(os.path.join(sysfs_path,o))]
> Minor nit: it's quite a long line; you may need break it. And space is
> needed after ','.
>
> Otherwise, this patch looks good to me.
>
> 	--yliu