From: Ivan Boule <ivan.boule@6wind.com>
To: "Montorsi, Francesco" <fmontorsi@empirix.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] where to find ethernet CRC when stripping is off
Date: Wed, 20 Jan 2016 16:49:06 +0100 [thread overview]
Message-ID: <569FAC72.3090001@6wind.com> (raw)
In-Reply-To: <30b91c74ca26434daac041713cffa153@bilemail1.empirix.com>
On 01/20/2016 04:02 PM, Montorsi, Francesco wrote:
> Hi all,
>
> I need to get access to the Ethernet CRC of received packets.
> To do this, I'm configuring:
>
> port_conf.rxmode.hw_strip_crc = 0;
>
> Now my question is: how am I supposed to access the Ethernet CRC from a DPDK mbuf?
> Is the CRC just the 4 final bytes of the packets?
>
> Is this correct:
>
> uint32_t crc = rte_pktmbuf_mtod_offset (mymbuf, uint32_t*, mymbuf->pkt_len) ;
>
> ?
>
> Thanks,
> Francesco Montorsi
>
Hi Francesco,
You would be right... if the PMDs did not transparently strip the CRC in
software when hardware CRC stripping is disabled at port configuration
(as described above).
See for instance how the function ixgbe_recv_pkts_lro() in file
drivers/net/ixgbe/ixgbe_rxtx.c deals with crc_len.
Considering your need, I think now that PMDs should keep the CRC that
are stored in received packets when hardware CRC stripping is disabled
by the application, so that the application can access it as needed.
Note that this would impose that the input packet processing of such
DPDK applications be aware of the CRC presence (+4 in the packet length
, for instance).
Let's see what others, if any, that might care think about such a change
into the CRC stripping semantics.
Ivan
--
Ivan Boule
6WIND Development Engineer
next prev parent reply other threads:[~2016-01-20 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 15:02 Montorsi, Francesco
2016-01-20 15:49 ` Ivan Boule [this message]
2016-01-20 17:15 ` Montorsi, Francesco
2016-01-21 8:49 ` Ivan Boule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FAC72.3090001@6wind.com \
--to=ivan.boule@6wind.com \
--cc=dev@dpdk.org \
--cc=fmontorsi@empirix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).