DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment
@ 2016-01-20  5:30 Matthew Hall
  2016-01-20 15:27 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Matthew Hall @ 2016-01-20  5:30 UTC (permalink / raw)
  To: dev

Currently pktgen-dpdk and many other external apps will fail to compile
if the build output directory name is not equal to the target name.

This causes problems if you used an alternative build output directory.

Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
---
 mk/internal/rte.extvars.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
index 040d39f..3d5ba1f 100644
--- a/mk/internal/rte.extvars.mk
+++ b/mk/internal/rte.extvars.mk
@@ -52,7 +52,7 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
 export RTE_EXTMK
 
 # RTE_SDK_BIN must point to .config, include/ and lib/.
-RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
+RTE_SDK_BIN ?= $(RTE_SDK)/$(RTE_TARGET)
 ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
 $(error Cannot find .config in $(RTE_SDK))
 endif
-- 
2.5.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment
  2016-01-20  5:30 [dpdk-dev] [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment Matthew Hall
@ 2016-01-20 15:27 ` Thomas Monjalon
  2016-01-21  5:15   ` Matthew Hall
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-01-20 15:27 UTC (permalink / raw)
  To: Matthew Hall; +Cc: dev

Hi Matthew,

RTE_SDK_BIN is an internal variable and should not be overriden.

2016-01-19 21:30, Matthew Hall:
> Currently pktgen-dpdk and many other external apps will fail to compile
> if the build output directory name is not equal to the target name.
> 
> This causes problems if you used an alternative build output directory.

Have you installed DPDK somewhere? Example:
	make install O=mybuild DESTDIR=mylocalinstall

Then you should build your app like this:
	make RTE_SDK=$(readlink -e ../dpdk/mylocalinstall/usr/local/share/dpdk)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment
  2016-01-20 15:27 ` Thomas Monjalon
@ 2016-01-21  5:15   ` Matthew Hall
  2016-01-27 13:38     ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Matthew Hall @ 2016-01-21  5:15 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On 1/20/16 7:27 AM, Thomas Monjalon wrote:
> Hi Matthew,
>
> RTE_SDK_BIN is an internal variable and should not be overriden.
 >
> Have you installed DPDK somewhere? Example:
> 	make install O=mybuild DESTDIR=mylocalinstall
>
> Then you should build your app like this:
> 	make RTE_SDK=$(readlink -e ../dpdk/mylocalinstall/usr/local/share/dpdk)

Hello Thomas,

Is the way the make install target really works documented somewhere?

This target did not exist when I first used DPDK in 2011, and since then 
I saw various documentation on building DPDK in various places, but not 
that much explanation what make install actually does. I recall various 
list threads about changing its behavior as well.

For example, if I look at this apparently most official document:

http://dpdk.org/doc/guides/linux_gsg/build_dpdk.html

It has build examples such as:

make install T=x86_64-native-linuxapp-gcc

But it does not discuss "O=" or "DESTDIR=" or any other additional 
options. From some experiments on my machine, it looks like maybe I 
could do this:

make install "T=${RTE_TARGET}" "O=build" "DESTDIR=build"

Is that a valid possibility, to keep it all in one easy directory?

Thanks,
Matthew.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment
  2016-01-21  5:15   ` Matthew Hall
@ 2016-01-27 13:38     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-01-27 13:38 UTC (permalink / raw)
  To: Matthew Hall; +Cc: dev

2016-01-20 21:15, Matthew Hall:
> On 1/20/16 7:27 AM, Thomas Monjalon wrote:
> > Hi Matthew,
> >
> > RTE_SDK_BIN is an internal variable and should not be overriden.
>  >
> > Have you installed DPDK somewhere? Example:
> > 	make install O=mybuild DESTDIR=mylocalinstall
> >
> > Then you should build your app like this:
> > 	make RTE_SDK=$(readlink -e ../dpdk/mylocalinstall/usr/local/share/dpdk)
> 
> Hello Thomas,
> 
> Is the way the make install target really works documented somewhere?

It is poorly described here:
http://dpdk.org/doc/guides/prog_guide/dev_kit_root_make_help.html#install-targets

> This target did not exist when I first used DPDK in 2011, and since then 
> I saw various documentation on building DPDK in various places, but not 
> that much explanation what make install actually does. I recall various 
> list threads about changing its behavior as well.

Historically, "make install" was a convenient default build (with T= option).
The DESTDIR option was added to make a real install after building.
The standard form (without T=) is now implemented to do a real install.

> For example, if I look at this apparently most official document:
> 
> http://dpdk.org/doc/guides/linux_gsg/build_dpdk.html
> 
> It has build examples such as:
> 
> make install T=x86_64-native-linuxapp-gcc

This command finishes with this message:
	Installation cannot run with T defined and DESTDIR undefined

Yes you are right, some docs are neither complete nor up-to-date.
Volunteers are welcome.

> But it does not discuss "O=" or "DESTDIR=" or any other additional 
> options. From some experiments on my machine, it looks like maybe I 
> could do this:
> 
> make install "T=${RTE_TARGET}" "O=build" "DESTDIR=build"
> 
> Is that a valid possibility, to keep it all in one easy directory?

Yes you can install where you want.
Note that this command (with T= and O=) will build in the directory $O/$T
i.e. build/${RTE_TARGET} and install in build/

Please confirm that this patch is not needed. Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-01-27 13:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-20  5:30 [dpdk-dev] [PATCH] rte.extvars.mk: allow overriding RTE_SDK_BIN from the environment Matthew Hall
2016-01-20 15:27 ` Thomas Monjalon
2016-01-21  5:15   ` Matthew Hall
2016-01-27 13:38     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).