From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 344E995AB for ; Wed, 27 Jan 2016 14:37:50 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id A5324755; Wed, 27 Jan 2016 13:37:49 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-6-12.ams2.redhat.com [10.36.6.12]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0RDbm55030653; Wed, 27 Jan 2016 08:37:49 -0500 To: Marcin Kerlin , dev@dpdk.org References: <1453824934-10650-1-git-send-email-marcinx.kerlin@intel.com> From: Panu Matilainen Message-ID: <56A8C82C.3080107@redhat.com> Date: Wed, 27 Jan 2016 15:37:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1453824934-10650-1-git-send-email-marcinx.kerlin@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Subject: Re: [dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 13:37:50 -0000 On 01/26/2016 06:15 PM, Marcin Kerlin wrote: > This patch adds new function rte_jobstats_abort. It marks *job* as finished > and time of this work will be add to management time instead of execution time. > This function should be used instead of rte_jobstats_finish if condition occure, > condition is defined by the application for example when receiving n>0 packets. > > Signed-off-by: Marcin Kerlin > --- > lib/librte_jobstats/rte_jobstats.c | 22 ++++++++++++++++++++++ > lib/librte_jobstats/rte_jobstats.h | 17 +++++++++++++++++ > lib/librte_jobstats/rte_jobstats_version.map | 7 +++++++ > 3 files changed, 46 insertions(+) > [...] > diff --git a/lib/librte_jobstats/rte_jobstats.h b/lib/librte_jobstats/rte_jobstats.h > index de6a89a..9995319 100644 > --- a/lib/librte_jobstats/rte_jobstats.h > +++ b/lib/librte_jobstats/rte_jobstats.h > @@ -90,6 +90,9 @@ struct rte_jobstats { > uint64_t exec_cnt; > /**< Execute count. */ > > + uint64_t last_job_time; > + /**< Last job time */ > + > char name[RTE_JOBSTATS_NAMESIZE]; > /**< Name of this job */ > AFAICS this is an ABI break and as such, needs to be preannounced, see http://dpdk.org/doc/guides/contributing/versioning.html For 2.3 it'd need to be a CONFIG_RTE_NEXT_ABI feature. - Panu -