From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id EF4B595BF for ; Thu, 28 Jan 2016 03:44:12 +0100 (CET) Received: by mail-pa0-f45.google.com with SMTP id uo6so15151241pac.1 for ; Wed, 27 Jan 2016 18:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=KwWfdjqYwWVVhi16iwIlOICE4eTFBRjZg6BFyDX3+YM=; b=bAtiUpW4XV3WA8HugvMhLLgPPGfxDPQCTLtnzOcU0/KysvReAxV/qEqyQ8iKvhQ4fI 9/Ash5HefTfzKYYzvCigyBP/HO03IdYeoKK+7xTXjQ2Y3hmb9rj9M0HyQrXYJJg1mjvJ YnH0TIXjI11QlayCqxwuhDGEjbIbWE+2CujgJPlmKaoyXqtXOUH16jGftaUicZByTFew mmq5JeSIEDEwxZ1Gj28GdqpyTMWoGRZR+d3wr5xEUYhzhhY7u8fp72teEL6Ls3Me7MKS xteYhVzVZzAcUvzecYHV4+3UqRIF4doZji7roDUrOqF07Tsk53fxaRuxfVLzqmU6AOc/ imEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=KwWfdjqYwWVVhi16iwIlOICE4eTFBRjZg6BFyDX3+YM=; b=F6ukM5NJboClVWyzOpeXLSFyspZ5RphiSYfwaZPbRXCr2k2DKMPlpJed7x18PE5QKo GkrffBT0q+XeiNsHDvpT/BPR+OPmepbjZG7CIvZAuedWMsWKGPJn1G7AHCa22qurBqRE dvlUR3t/s/wnmjSCVCHKQ1ipjhXKjvzmfhZk6XsgP6rdsKakEg8UkovgXThvdK61Jo8i 3IXAFbadREsKHN/JphW1aei3e34TQbBKvB0pv8juwqxj8p/rSwoA0zGiPZDq20XVIDMC 0XA07iq7vx6fGXNLTqaTdCsmkryC32smzLtrKSYK5c215Nwr8R+TBZylxhivzJElNkb3 wNTg== X-Gm-Message-State: AG10YORQQqHM10dIDjSZKv8wU0JPnCybMEnsL1+7OiRRflC3ljUE3ygLZNoXWya+RbIJsA== X-Received: by 10.66.236.69 with SMTP id us5mr904496pac.93.1453949052380; Wed, 27 Jan 2016 18:44:12 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id tp6sm11950605pab.25.2016.01.27.18.44.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jan 2016 18:44:11 -0800 (PST) To: "Xie, Huawei" , "dev@dpdk.org" , "yuanhan.liu@linux.intel.com" , "Tan, Jianfeng" References: <1453108389-21006-2-git-send-email-mukawa@igel.co.jp> <1453374478-30996-6-git-send-email-mukawa@igel.co.jp> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <56A98078.3030708@igel.co.jp> Date: Thu, 28 Jan 2016 11:44:08 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 5/5] virtio: Extend virtio-net PMD to support container environment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 02:44:13 -0000 On 2016/01/27 19:03, Xie, Huawei wrote: > On 1/21/2016 7:09 PM, Tetsuya Mukawa wrote: >> + /* Set BAR region */ >> + for (i = 0; i < NB_BAR; i++) { >> + switch (dev->bar[i].type) { >> + case QTEST_PCI_BAR_IO: >> + case QTEST_PCI_BAR_MEMORY_UNDER_1MB: >> + case QTEST_PCI_BAR_MEMORY_32: >> + qtest_pci_outl(s, bus, device, 0, dev->bar[i].addr, >> + dev->bar[i].region_start); >> + PMD_DRV_LOG(INFO, "Set BAR of %s device: 0x%lx - 0x%lx\n", >> + dev->name, dev->bar[i].region_start, >> + dev->bar[i].region_start + dev->bar[i].region_size); >> + break; >> + case QTEST_PCI_BAR_MEMORY_64: >> + qtest_pci_outq(s, bus, device, 0, dev->bar[i].addr, >> + dev->bar[i].region_start); >> + PMD_DRV_LOG(INFO, "Set BAR of %s device: 0x%lx - 0x%lx\n", >> + dev->name, dev->bar[i].region_start, >> + dev->bar[i].region_start + dev->bar[i].region_size); >> + break; > Hasn't the bar resource already been allocated? Is it the app's > responsibility to allocate the bar resource in qtest mode? The app > couldn't have that knowledge. Yes. In qtest mode, the app should register above values. (Without it, default values are 0) Usually, this will be done by BIOS or uEFI. But in qtest mode, these will not be invoked. So we need to define above values, and also need to enable PCI devices. In this release, I just register hard coded values except for one of ivshmem BAR. In next release, I will describe memory map in comment. Tetsuya