From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0084.outbound.protection.outlook.com [65.55.169.84]) by dpdk.org (Postfix) with ESMTP id 4C39DC444 for ; Thu, 28 Jan 2016 12:17:54 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Kamil.Rytarowski@caviumnetworks.com; Received: from localhost.localdomain (213.17.239.108) by DM2PR07MB1450.namprd07.prod.outlook.com (10.161.139.144) with Microsoft SMTP Server (TLS) id 15.1.396.15; Thu, 28 Jan 2016 11:17:51 +0000 To: Thomas Monjalon References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com> <1872674.ygjbT6ghrC@xps13> From: Kamil Rytarowski Message-ID: <56A9F8D3.3010605@caviumnetworks.com> Date: Thu, 28 Jan 2016 12:17:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1872674.ygjbT6ghrC@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [213.17.239.108] X-ClientProxiedBy: VI1PR06CA0083.eurprd06.prod.outlook.com (25.163.160.51) To DM2PR07MB1450.namprd07.prod.outlook.com (25.161.139.144) X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB1450; 2:XRRB5MR01FV2aAEYZfaMHEkmfgCld4GWmzF8jq/EaaONRpUl+IxlFhiVox+/GS2k2VHorjF2AlM41xguDStqi3fevLpsrWhIqbeL0s1thIjKFKCVPuhWSFDKFgTY8aD9lcv6znZvpJK+sBqKDdBxxw==; 3:ZqlCDB49aSOjVKcAtyQDpaes6hfZzNb6MQ5zTuV01Mo/8d6HNmJZ9Ax1O9zYw9P9GyPmfiBd5iv0+SaPldBVEEd+REZMVKvkkFK8gY4Ju9bLbcORXycPOh5KVtWwV9Jw; 25:Pd4Tz0oUYpArkqXJhkj2FBCLrbSjv0Gu6MTIAOgpsmISibKUx6g3VKyZ+vZMQE7pYEByDYdedpFLVsJ4wy6LkrGYs4lr2Fh3uvcTyJy25rYMcCmVdXK71WgkD5tO3WEQZZXIu1ASnv8CvqvBlNWuTtMEH8KTnTYqnqwJ3isYzn0w+TIQ7HgxbmtFPlhTY82btnE2k/ki4rgWEnYorz6HCTMcF9nXW8KVccYwuaqdE7OGz4PRQ/KKCZAqBANWxe2P X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB1450; X-MS-Office365-Filtering-Correlation-Id: 4fe12e6e-5cf7-4953-5869-08d327d4a9fc X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB1450; 20:7q5sILANKSffZY7NOeih7/QclMnoBBywDz87TveIJVTLF4U0vR27omz77dOxf1sk/jcOJYRaldwtYdMwYHmZcquf4kxs5RGdP5lQrQHDdOFBc5dwFew/JzN7xsArMiAnq7isnJNYPx0g9yDF7oDUCTC1eLfpMidg5cTWC9souwUVvqBuFhjFqZIpHuNa6b80owVu3848CLGD1pQ1E/f83Y2pk9T359fpQoW1ayG2Q02Zoqqn8xTb9t8Xj75+xWiNX8e43ILlBKPfM9HQww+ytdStXTZSi3FhAcHuuS1CqJaZhdXq3aYmBiQHpzucek7t8PAkJ4RnD3FYJu40sFomt9sJ61TTlmIxbOamw9cQj3j/RRCAaIZfHuUW3TM1HZ5CEiM8LOwwi3D8rWCWteE2KoIaCnOBXWv3pD+AzVdSw93Cx+n5jPLKMp9bW0GeSiOa0FKluauV3Y0jhKtByOnmG6URnAvjqmcjLM+dxrlH3mNeOH/JoOwQ6Q9CudCgtQWUPPE2+9BviUUBOWzTirVnpJvzS8Ch8UBAq51h4qeg+4oExc2EVDljME/T8+YRyIulTaNz11Nj8jMjb5Kc7nBiAk5RA7+1NncjAC+eUUM7Wq0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:DM2PR07MB1450; BCL:0; PCL:0; RULEID:; SRVR:DM2PR07MB1450; X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB1450; 4:K8aJWn5kVZquKzSvD7A8UOwdRXDBvYgt0CRKse9q+YsGe547CVYpMo+BTZr6cXHKYZysm1JBwwWxN9gOacnLF9cedxAp2kWKJ6BMMHiFmeOYBSzqV4cxoahQl9o7UQ3e97GqvpEx5Gi0/QcjlIGgARj5HFfl2frbzvmU8jrbl0hPOeKwGDyDLKGNVuCiH1CqaUwnjzF9fwgXy1/kSqkJgPkA4nZq8N5bPtgi5V+zacwwKEdDX9TAazFljr9fWQ+1U0F/AizRX7GXOkm09WXthKwxn2Uyue37HwWSG9iSGrlhq76CXcchkoa6mbMpOGFasU1klJTp7nZnxylBMMDYhd9rZbDcxhhtWokpPg0H6lQvUmEecgC1eRCkeGaiHfnD X-Forefront-PRVS: 083526BF8A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(189002)(199003)(377424004)(105586002)(19580405001)(5001960100002)(77096005)(40100003)(19580395003)(80316001)(2950100001)(5004730100002)(47776003)(110136002)(122386002)(50466002)(65806001)(65956001)(66066001)(83506001)(106356001)(59896002)(2906002)(1096002)(4001350100001)(81156007)(4326007)(42186005)(65816999)(76176999)(50986999)(54356999)(87266999)(92566002)(5008740100001)(230700001)(97736004)(101416001)(33656002)(64126003)(87976001)(3470700001)(189998001)(6116002)(3846002)(586003)(23746002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR07MB1450; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM2PR07MB1450; 23:vm8OIWQgBvFE2oS6BHKL4Kl2eQKcD0Lv1KpCN?= =?Windows-1252?Q?61X6p4M2PFPDLvdycgQmFrd9m929x68pruWh58LD6TV5BBJOWwPdkiLc?= =?Windows-1252?Q?48/YVIgIghg3r96usv0BpiseLayW0GVulnUGhqgsLXXZBoYrENBDnGh9?= =?Windows-1252?Q?KBQXqaMqKzr+hdshFSho4NjmuBTzcTK13uXKUg6NZrr1lHouv9ich0Xu?= =?Windows-1252?Q?39CDu47odNldvkjb7IysUFy5eiX2vA4ApeEkTDWUFlaTUoHxAji+AVlK?= =?Windows-1252?Q?daVhJLJtdI6k2Ev/ETD8W93mqoLnrabH0C1HSoMOOt1JhGyA8yVW8roD?= =?Windows-1252?Q?36ahGtvOUEYDy0dBGP3Xn5oSocg7fkDQrQAAX/UaQx9F70Dg+eYjQIOz?= =?Windows-1252?Q?TWoEmQQ/sXrgZuW1sfEX+i9aHSstfwp8d3aD5DQ9YD/CVXU+iP9dHzbD?= =?Windows-1252?Q?PL7GCC1uRhdHWJDQCMkxs6cVmWOqwhCm5GakRzCE4FeMO7L4zbtEoQpK?= =?Windows-1252?Q?chxApu1fZZ98pOexUAw3DnWUpuwYU1IUgQcRuVtrjDJ+7Aubyj6LEWck?= =?Windows-1252?Q?aSpbGn/aNMNVSAWisgtNLwuNkjTAcyf9CTqSXtdR0w/P6mHZHnMav/vB?= =?Windows-1252?Q?/+FVYO/ho9O7h6KLmldcYP0WJseEOD4X/7+v6Ywthr4emDsV0Gvk/dDM?= =?Windows-1252?Q?X8n8HJh0C9edRLvDv86QWAyVboy3tiS9z9SAOjsNPYuXPD4C/kYwQ4jF?= =?Windows-1252?Q?05dUA0FoRevg+HAkgvO0mTlqppP47tbg9CSie/5uLuBSjDcF1jKx9nkt?= =?Windows-1252?Q?/pIN6E9EaqFrwfqrEiR76/Foo/YRQ1MEIwtjh2XvBp5Sby+UUnTqh/XW?= =?Windows-1252?Q?K6QrEnvC9RNsE6VN2JGRoCnnqPhGC67ZehZjZ99PHM1S5uH7c845bGmC?= =?Windows-1252?Q?4npnurkJZAkCCp7+ES0fY1Hv8H+CnVwDhw3b+czBnJnpqkVGCZ6/5giX?= =?Windows-1252?Q?eFcWKNMKnTiJXDv8mNaa8aDTdx8ZTAhyRQfFNrMljr9g7kx2f5FeY8U8?= =?Windows-1252?Q?Q911FxgvzmazfGAP9UEbwm7iKs97HqlU6OryzeYng6jdLU44tQonPX0W?= =?Windows-1252?Q?OTJyvM1q82fhHHDrsG7TfVYn5911RGn0hVLb7p7OkJQaHK/ny0qo0i2w?= =?Windows-1252?Q?5sR/sRcrL4d5bJ2WE0Bb84dSSMnJ9gSLNOyngTL+xCX1AxI/zfVkhx5k?= =?Windows-1252?Q?7lpRTiYP0o3rV8hBfHgQRBPCghtR1VetMpIOdp9z/2O26ZSk1G+Pzb3d?= =?Windows-1252?Q?eA/W6um1xJ1JKIKsG4+TADKDdyqvobMdRoW2TOkjWtjgFZoyyXQBjJl8?= =?Windows-1252?Q?AUofNJnqpAJ?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB1450; 5:6l4tZ+6djouyOZZnDRodOgD3PyWqi/cFfkbF6mc1f7m89CUp4jTI1VlKTzF6wUy8m6/xPPgWBPSbx+DLy3XLKlbR244K0pdSspoYIR9d6K3rjl+tHpIqaXD4G5p5H9I333cfLStGSrqafb9SpESOIQ==; 24:KbRKf7i9H6+7wSBCEOTZjZ9PerOC6eOHpy1luFPy/ZJz68o4IcincA2tTvCBXBcf1u15OD3xoOZyqDeA+OxZmUvT9jT5nrLn6bUV3wi5exk= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2016 11:17:51.9683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB1450 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 11:17:54 -0000 W dniu 26.01.2016 o 16:23, Thomas Monjalon pisze: > 2016-01-20 10:48, krytarowski@caviumnetworks.com: >> --- a/tools/dpdk_nic_bind.py >> +++ b/tools/dpdk_nic_bind.py >> - for line in loaded_mods: >> + try: >> + # Get list of syfs modules, some of them might be builtin and merge with mods > Please could you explain this comment? > Is it remaining from previous versions of the patch? Yes. It might be changed to: # Get list of sysfs modules (both built-in and dynamically loaded) > [...] >> + # special case for vfio_pci (module is named vfio-pci, >> + # but its .ko is named vfio_pci) > Isn't it common to have dash replaced by underscore for kernel modules? > I retained the logic for special case of vfio-pci. At the moment (according to my knowledge) there are no other DPDK modules with this name replacement. I checked few example Linux modules and if a module is named with dash, it's being replaced to underscore. The modprobe(8) tool can accept both names as interchangeable (with dash and underscore). Would you like to make it a general rule and replace all dashes with underscores? Thank you