From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 70574C458 for ; Thu, 28 Jan 2016 12:22:21 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C8E1D71; Thu, 28 Jan 2016 11:22:20 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-63.ams2.redhat.com [10.36.4.63]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0SBMJUc013722; Thu, 28 Jan 2016 06:22:20 -0500 To: Kamil Rytarowski , Thomas Monjalon References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com> <1872674.ygjbT6ghrC@xps13> <56A9F8D3.3010605@caviumnetworks.com> From: Panu Matilainen Message-ID: <56A9F9EB.4090906@redhat.com> Date: Thu, 28 Jan 2016 13:22:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56A9F8D3.3010605@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 11:22:21 -0000 On 01/28/2016 01:17 PM, Kamil Rytarowski wrote: > > > W dniu 26.01.2016 o 16:23, Thomas Monjalon pisze: >> 2016-01-20 10:48, krytarowski@caviumnetworks.com: >>> --- a/tools/dpdk_nic_bind.py >>> +++ b/tools/dpdk_nic_bind.py >>> - for line in loaded_mods: >>> + try: >>> + # Get list of syfs modules, some of them might be builtin >>> and merge with mods >> Please could you explain this comment? >> Is it remaining from previous versions of the patch? > > Yes. It might be changed to: > # Get list of sysfs modules (both built-in and dynamically loaded) > >> [...] >>> + # special case for vfio_pci (module is named vfio-pci, >>> + # but its .ko is named vfio_pci) >> Isn't it common to have dash replaced by underscore for kernel modules? >> > > I retained the logic for special case of vfio-pci. At the moment > (according to my knowledge) there are no other DPDK modules with this > name replacement. > > I checked few example Linux modules and if a module is named with dash, > it's being replaced to underscore. The modprobe(8) tool can accept both > names as interchangeable (with dash and underscore). > > Would you like to make it a general rule and replace all dashes with > underscores? It would be nice to behave the same as modprobe wrt dash and underscore, yes. - Panu - > Thank you