From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0067.outbound.protection.outlook.com [65.55.169.67]) by dpdk.org (Postfix) with ESMTP id 98A9EC3BA for ; Thu, 28 Jan 2016 13:54:25 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Kamil.Rytarowski@caviumnetworks.com; Received: from localhost.localdomain (80.82.22.190) by CY1PR07MB1448.namprd07.prod.outlook.com (10.161.167.146) with Microsoft SMTP Server (TLS) id 15.1.390.13; Thu, 28 Jan 2016 12:54:20 +0000 To: Panu Matilainen , Thomas Monjalon References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com> <1872674.ygjbT6ghrC@xps13> <56A9F8D3.3010605@caviumnetworks.com> <56A9F9EB.4090906@redhat.com> From: Kamil Rytarowski Message-ID: <56AA0F6D.3080702@caviumnetworks.com> Date: Thu, 28 Jan 2016 13:54:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56A9F9EB.4090906@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [80.82.22.190] X-ClientProxiedBy: HE1PR02CA0010.eurprd02.prod.outlook.com (25.162.33.20) To CY1PR07MB1448.namprd07.prod.outlook.com (25.161.167.146) X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1448; 2:7w8Esz/F6RdR9mRWKc5f7MgTdMmgssy06oR3j+iyxReIPoH4HxoOqDFrdMvgoHGOZWrR/yV9iAgfsiZx3U8L5RW6bCQ/4yexcm/FCApRYYoKFnYbKy6YTO/Ak/nV77HK4tcGAN//RXf2JUJE8+tC/g==; 3:RCB+69lEV5p13gbZiMa5MdS3QH2Ues9o1u26D5tJ/nBnEyI9gv/PUR9lkPwXBX3t5+rkO0usumH4fBrIXYcypfHuPjGiy4Ykwx+dNK1Meax3Z8EaEztoTd+1IUvYzplV; 25:F4f80MYNEnsIrVJTNb0BP1jh0OSLFe5PTkoJSXUBMwesUQ+DrW9Q1Nvv0n9P+GS4aIAobUYuE2GqmScwqSxV4tbiIdxDJ0VBrQXZtlsxGJa318ANdDVUGB+lczTin74srAO6+dEdUpgDm1znBEuI/u+bH9aKdLdEwaVDfoQhAxlVTDOo0ie/Gw84ye1qyJhvlocjEyGQx9NLLyI2NuKBSjs0WpvvHS5rqZBbO98R+przh6OHff3C/v7SvEhOPW1Y X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB1448; X-MS-Office365-Filtering-Correlation-Id: 1cb19283-11ad-4502-54bd-08d327e22434 X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1448; 20:fKvM6AQg495zE6DApNuLbcyIVdBKH43B0qDxE4JkYfGbpaFh8zAIqAqFk9boK3La8V4DmsfLDxk8PrO8ZCCtrecf537lRbE3DdZwKu7thX84guDzIn8vA9UfTm5vHGYWk+wZAbo9bor1oVMJkoR8qdcgSJ8QBSXEf9RQLNpwWKoJ+orku2foNTz1/LbTUlz9HMG2N0IrBVvoA8eubY6e87KE+MDj2j+1AQ5cplZsxlfpiarXjqWPDWliYloVqvPzXrJI8DbTlU6T/Z5KZuoBqUryD1UCyg2PnMpazzAO4CJ808qMiagCjr5wMIKk8XcDj8dw9llYBeUQ3Pd1nT85CyKWvPcHGogmNkxiqFG40EG7XA2ufmAKZeIDeCpGVxJ70APCs5Ua9NrFEC/8traBiEaPDl9rjaY9Sq38KKG3mk9DnU+A7+Lc6tjYmHGqooUQ4KB57LN9XTrFwj/DHwR0rbUty9EF4/o/7omi4QF9xqucpBT38eNZ6LVANK9XIRYU03OJetqx9YmKWJw3HUWcBgeGXMbuUj9UHv7di4LFCkT/YnSl3Isau0v2jT95hi+jBoJoQRERJ/QDFXpjTcd1n/Ugf47kWhN7p+WgWaG+vIU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:CY1PR07MB1448; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB1448; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1448; 4:sK9kSYPKs1o/OE51HmdaQ84DFYQtrXb1Y4Ik7fMa/5PfjCYSqytFwySoQzrTQ4rjNQbaLVslFUcFAbaPghXiRC/kKxNtE5zNnPGtweeQEV9nhocm1R4Vz/XomNSO03TAYLKRQIX8Bz7yXBicsaZ+Hz0A4T85ybsje0xOUQSenMxec9T4Eykf/mFHrxy0bATrsswtXAH6MaC83wZh+ouSp7MfuYuPI9oOc9L4jZoJCg6oU/xtnKOXEo9TYrgr7Pfr/E4Ik0IDyM0yoZ9AcFjb10drjgcYu+P3fhwqBDz3FUfZwwkP00P/h25BydyMJvx7aYkIFj8dBOv0pVNi8/l6gyxdaUfo1d6i2gKJ86BuSx3r2clTabZ0Qu7fqKybgchC X-Forefront-PRVS: 083526BF8A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(189002)(24454002)(479174004)(199003)(377454003)(97736004)(23676002)(83506001)(93886004)(5001770100001)(5004730100002)(101416001)(105586002)(5008740100001)(6116002)(54356999)(122386002)(3846002)(189998001)(586003)(64126003)(77096005)(106356001)(1096002)(50466002)(42186005)(2950100001)(66066001)(87976001)(65956001)(5001960100002)(80316001)(76176999)(4001350100001)(50986999)(65816999)(65806001)(36756003)(3470700001)(2906002)(4326007)(87266999)(230700001)(47776003)(33656002)(92566002)(40100003)(81156007)(59896002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB1448; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3TUIxNDQ4OzIzOjdJUExvR1ptdFRmY25MVmZJTTgrNnE0LzR4?= =?utf-8?B?Szh4d0ZFWkkwQkhJWmJEeTZlcURFY25ZeEdobDJoK2RmcWpIOENDU1RRYjY5?= =?utf-8?B?dUE5blBrVDZIQk1tclZZS3BrUVJBZFM1TCtSZHFteFRFR0ZnVm5OS0R2MUxo?= =?utf-8?B?dGgyWklpSEYvZUFPekpVSEJ6dENub0NDL1lKR2tXM2xURUpIN3lBTDBRNUR0?= =?utf-8?B?VEJSQVhrVUVoUEkvVzNwSmdqVDEzYm5HM1dSeXQ4SEcvTU9QYWswQmhDT3Za?= =?utf-8?B?RVpsZzZ0cC96Qnhnd1VTOFJjWkJkdW9oMGI5d204K29DSTBralYxZ21HWkRx?= =?utf-8?B?MzJyc3VJejZPWi9hRE83U3puSjlHZVRHK0RtajF0eU1QRHdnNGFqQlFWRVRu?= =?utf-8?B?TytVYndnN0NaRVF3Q09sTnNOMTJuWVRKbUoxVkxnSTVKWFFvSDAyV2p1RzdU?= =?utf-8?B?MVJRUm04SWI5RWpHTE4yaUFackozSm54WU15YVVpMVZyVkcxSDZ5RzZBY2RO?= =?utf-8?B?bjBQU0YvOHNsRktpaFdmQnc3TG42YityNWVMN3dLUDNSZnNhU2FaVkw0WUNS?= =?utf-8?B?TnFTUVI5MzQrcStiSHViQnhrQjRiZUNYaU56bTcyN2tVZE9Xa0ZNeFdpWHAv?= =?utf-8?B?andRSG1Bbnh4OElwN1ZDakExYXBRaldaOWRoWDlRRUlOWktQNzJzNjFvU3RG?= =?utf-8?B?RXFhYlBVdWdSQTU5bkh3dDVGR0pIaERLMXFZK05EcHVoUDhrTWF6cUtGeGZT?= =?utf-8?B?MHhGcXFNRFZqVHAzbU9VVHJIWERVaEFyS3hQb2FxSytqMFBNVy84eFUyaXIw?= =?utf-8?B?WkNScmNnWDZmNDBoUUs2RlhRV24rS0dJbGVkamRpdFpmWS9jZXNvcm5SRW9V?= =?utf-8?B?aGFyK0hjSWM2Q1daa2xLMVYyc2ZMR041RVQxMFh2MWJHb05CaWdzQURINHF1?= =?utf-8?B?NkcyZXluSStia0VUWFh3dzdibU5MZFFKOFBUMllIVkd2bFRETjQ0OTYrRVY4?= =?utf-8?B?Z3QzYVZrNUtlaWk2Y2YxbWtkN0tod2FVbUszN0l6WXMzZkN4dnY3T2JMSGgv?= =?utf-8?B?bWROK2FZaHI1Y0Jpd0xuM25UVmdhL0x2ZnljbFF5RlNZVE5BeVpMaU5ucGJW?= =?utf-8?B?Q3RFaG51dDBXUFRGbHJmbzZIbTAwbjRFWTc5UFhJYXJSakNQd1c2aEoyLzE5?= =?utf-8?B?NU45YkEveDFtVzQ2cGsyWWNTSnYxU1JNUlk0QlZPQ2ozaDdpc2IwL1N2K01O?= =?utf-8?B?WFRWWXh1cWptcnBidkpMbGxXY0pwcjNRQXZNYkhDa2RxS0M0K3E3MEgzdE9G?= =?utf-8?B?S1liZEVHMDY0aWtZOEdtSzE2RWxsY1I5UTZJQ2t1TzN0K3R6bEVuZHI0Ly9F?= =?utf-8?B?OWhHekZSQ1ZqZDk5TXBCZ29vMUVNTWpUTC83QnNWdzF5dzdLTlBTRmRNZEFj?= =?utf-8?B?eDdZY0phYSs5dzNIN0QvMisremtFMVBGSDdUMmhpV0l1K1VpeGVaNlRkWVhR?= =?utf-8?B?M0I5OU5zempCY3VOQ09mNjdadEszczM5MFBvZy9VR0J2VGdaR1BralpsZWRC?= =?utf-8?B?L0RZYlVUSHNpY0NlV0RET3ZxMzRjTTd4Sm95bGdQaEhCclRSYnp5L3MyOTlB?= =?utf-8?B?Q3lXc09uU1J1eFhENkJTVlJDOXFVcXJEVndsLzFBaTllU3pZMUt3Y3ROUit4?= =?utf-8?B?K2FjNDNqS2dZQTVheHBvNjdhdUoxb045bEtwSVdDOVJmN09GSm81clQwbXFv?= =?utf-8?Q?2g5K15LJ7rhDNGMTLZdWFArKDZVOnO+HnwShs=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1448; 5:shjeTwLmvHKrog88iLOHdDPmM71AmUiyEMvmwOA4Ooto9/vqXbVpKa0nw31beIOhOlvFQEbIiq/gPvI73lVLCutmyD+OifWzD1dQuFjd9FOyThHrf+B3D5lCFVOcRVKyWxtUssOXe2sdNQknDRRC/g==; 24:azu19cRr9fLKCmmGMXOxUFSiWcdLkEC1S8p2rNj4RVqYhAwmV7np97Mcz8W7ag28Qty7lOQ9BZVDDZdO3WAVImpM1hAq7Gf5tHs6nHBGJlA= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2016 12:54:20.1936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB1448 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 12:54:27 -0000 W dniu 28.01.2016 o 12:22, Panu Matilainen pisze: > On 01/28/2016 01:17 PM, Kamil Rytarowski wrote: >> I retained the logic for special case of vfio-pci. At the moment >> (according to my knowledge) there are no other DPDK modules with this >> name replacement. >> >> I checked few example Linux modules and if a module is named with dash, >> it's being replaced to underscore. The modprobe(8) tool can accept both >> names as interchangeable (with dash and underscore). >> >> Would you like to make it a general rule and replace all dashes with >> underscores? > > It would be nice to behave the same as modprobe wrt dash and > underscore, yes. > > - Panu - > My patch is intended to support built-in modules, the rest isn't that trivial without changing the behavior. I prototyped it and it added extra unnecessary complexity, while we just want to handle vfio_pci -> vfio-pci. I'm going to submit new version with improved comment in the code. Please continue possible improvements in separate threads.