From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0067.outbound.protection.outlook.com [207.46.100.67]) by dpdk.org (Postfix) with ESMTP id 919D4C48C for ; Thu, 28 Jan 2016 16:33:37 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Kamil.Rytarowski@caviumnetworks.com; Received: from localhost.localdomain (213.17.239.108) by BY2PR07MB1442.namprd07.prod.outlook.com (10.162.76.144) with Microsoft SMTP Server (TLS) id 15.1.390.13; Thu, 28 Jan 2016 15:33:34 +0000 To: Thomas Monjalon References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1872674.ygjbT6ghrC@xps13> <56A9F8D3.3010605@caviumnetworks.com> <5908931.I9BmIPpWAU@xps13> From: Kamil Rytarowski Message-ID: <56AA34C2.8050906@caviumnetworks.com> Date: Thu, 28 Jan 2016 16:33:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <5908931.I9BmIPpWAU@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [213.17.239.108] X-ClientProxiedBy: VI1PR04CA0020.eurprd04.prod.outlook.com (25.163.3.30) To BY2PR07MB1442.namprd07.prod.outlook.com (25.162.76.144) X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB1442; 2:LrBkG5/oLFv4LVhRMtAqxx93G4IwCcFDTYC3+uwiNehwhyz627dxqf9g/88xw9UrxkhPf1YB4lx0sVw2WSYZ+FfF00uDiWaFGNbGcdXnOjRprNXCaM2JkHQVY/qI5rk/Qe6vXape/0RfVkg3Fu+yuw==; 3:hjFgOPdzOPmlApCnFOGABox7o9DeSBT+vFRsgB38kd51DUzmoK+8/LyCER4kIcAS7NYq/IRHQknXaSZKcCkeRfA93G2Fzdp3tT0QBezqDoXDrFwQv7PFWUOVeTb/crjq; 25:mOh2toLQNlioed6p1fpDJ8+d8VINzvUEbsfLhtdLun1gErcEUcmF2SUghphemM2Q40nR/SSwtr6JmZhPrLN0e8ol/cWYrrVlBV0zUk/V+30nYkkloJBDZC+xbAJONS3nzVpkUdjS+SRiCVqLVkYSc5T19PGMrqA8lO9OtxVZiAhzn5OpKd/UEA/rdXjgyeilCL45St+966/YxvW4aLWtUwdCQoAtipiGzj0HKx4tBkNa1rEqzPhEQqyIeWpg2JqK X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB1442; X-MS-Office365-Filtering-Correlation-Id: fcc15394-7b90-4c2d-b286-08d327f86357 X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB1442; 20:JEmleubzDpf4XQWTv0A3ZOIsG36Lw7tXcXnecOASJbScHUdm5c4gr1br1A4rL/qENHMUSjasFYOe5RSNz9nX9fz90ZXGvYnhOT1T2hBnV2LXWi1e4n+ka3pxkG1BlNzeuWTH7gi6cp9LxQh3ge5zy3DwVUujcBCvtgcXahj9JXEoA/hatIJvwRi/ENSfzbr+i5Dn6m8oyvqae0X7njpgy/2foWJBNYTIkvTpoYfLTQwsoA+FTc7QO4hn/VPcg28DZXRk8hrU5KOM6EBhOHoIWrIOBo6MYe7Zvz/4aYTuVB14NphvwzBwKJZchx7/kwCAMvybalHviUXt1jeBEUnp7Bsm+Taozez5NSrEgR/o6FeuBIk6FqvmqYcaE+tsRn4i/3oVaACCVimoG8PoMkcx6NMHzckk+C+Ddfu6Zh8b7HtzlPIZwBOEe+7hWe4PecGFLh+fWJshjLD3q+SSjv8Uv3pn2Krb+XCAVl5mjS1Tpcl4smNgY1F4vn5IP5FkazUQ8134UhEiKfRbkXpSOYTc1F3V5W8fDhNV3/I/1tbWe4M4jXq5chniG8VRl/uQYJF5UkF6gYMsWYpHHF/A/hWZ2TVSUufa9BRFzoLWe+NtH5M= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BY2PR07MB1442; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB1442; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB1442; 4:udWJLOZ3t9uOyy818WtxwAI6sacpFi3iTzFAPBZqZ9Y7ip/1jg1xd+kgH/lXFcelywI9i6RASPz4PBJOYDnszibefaDw3wxDfhZ+nangAvy0gUpBFB/hAgl25bDdGFpK4QgmB7RWzRcU8iFF6FwMD9C4kd8ExQs3OPaJcel+9Ny+mtDMpX/pWZiyc0E5FdxZJoHY46V5kBdU4ixzi8cAuqm38XC00710fq95FQCHvJSpFPryJ+OU2v6r7YLpkP+CEoqBD3YvjuF/VwVLEeYRFXhSbvFPTOkg5QMr3bUCWHhD1E3F2BDiqLEqvAhbXNstvu/LiEXfax9VnrpDdjShzINcABQGnShTdZZspB4Pr9XPtQzGNzd+A+s7u30uW0rU X-Forefront-PRVS: 083526BF8A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(76104003)(199003)(377424004)(189002)(87976001)(81156007)(97736004)(4001350100001)(47776003)(50466002)(65816999)(110136002)(93886004)(80316001)(50986999)(87266999)(230700001)(54356999)(76176999)(83506001)(59896002)(5001960100002)(66066001)(65806001)(105586002)(77096005)(5004730100002)(65956001)(23746002)(189998001)(2950100001)(106356001)(101416001)(33656002)(5008740100001)(36756003)(122386002)(64126003)(4326007)(2906002)(42186005)(6116002)(40100003)(3846002)(1096002)(3470700001)(586003)(92566002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB1442; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR07MB1442; 23:rViOScFfwmyRKF2w9ysbxdCdgmwW9NfoiyruY?= =?Windows-1252?Q?dH9oIIxXgmg9UWMiLso3r5LNooLDI0kCV2wVct9hRrmA7ZiYxI1FOhJo?= =?Windows-1252?Q?wiQ/xhalgZJaj91Yp5KrFMg1uMp0Md+qJ4mwKfpQWSykWG4c5S+15VpB?= =?Windows-1252?Q?5vCHikyaMeSQwt15/ZBqgoFLsfRJ4PrnHf+IMF97w+IXy79nnK35rw2O?= =?Windows-1252?Q?FNjw2bEss4WNa3Ek//VenETyryIRGqNhW2wy2YH8dVE1VpUrRC0LUVW5?= =?Windows-1252?Q?oB+pKaABxYdT3A7w/0Ys8qbOzRIhku8tZzEjoHOv+SRNRggDW4mazwCR?= =?Windows-1252?Q?oQHZPdkmNKB2zVJgby6xHZHOe3ZODVs9r77q/HLEYp10Cmx2vYRbxSHm?= =?Windows-1252?Q?B2tcwFJuYUugjWUMMbT3VqNM1FYbsRr7yPSkQQqoZcEGuFY05HTBfW8Z?= =?Windows-1252?Q?7tXVZ+89v/Ldx6jgK2KjdnQU57836DwQqJDNzMANTzWqmGZOctdoMpwH?= =?Windows-1252?Q?cXPTpZC5qB9SAr+QLSvngVt1btCfqt9AOaTvT9xM0JYv6aoT267mA5VD?= =?Windows-1252?Q?qV7d+P+O7G7uWIbvWR162uV4NYzUhw6iaZpx0PeoD7ztrkIB6crF6H7Q?= =?Windows-1252?Q?fzny0wB4yRU9IC7jaCofEZ176d+ANbkmhWguiLRdPWpJVY4tQ7dR/5tq?= =?Windows-1252?Q?p5SoJm108gDTMsNEk8VSUaCV++rPZyHMpsqPsrvTa9ovrefqoagqHczB?= =?Windows-1252?Q?J3w5YbZUWrFuHGN2O4/CTVQPGPg7Il4BLoAVWKJYCXiYTTZR9mmYrHPV?= =?Windows-1252?Q?Kbe3YDrp/1c6dZZ92yoqPw6pCXbXEOL7l0S+rVdFW0fYo1JOjlOPAydz?= =?Windows-1252?Q?FbrJUxwnCeR4XdVCCFfjrV/KrT5RzrN9TKc5vsF4SNyfcEFfv1rpzYYt?= =?Windows-1252?Q?Rphc7SPNWwbgvdMe/oCfAJFlxypCw7ihyihe/QX8rNcpPqkUZL2ofI41?= =?Windows-1252?Q?k4IY2UQxessHR/ahdzyhxSl2X16alwsSzupMXYhhtKIr1V0THFkQP9ZL?= =?Windows-1252?Q?ptaAlvIHvUAPIONdLrqOgooqZT76qj+P3zs1XAmpoyJqeXAu9gI+RQNn?= =?Windows-1252?Q?IcuUzn40ptmjvE/YCU8Lp5Q0OCDNh0oC/Bb8o8f2WZ7RwkGroKiu3HtP?= =?Windows-1252?Q?fPYqCJ+wi7HBRVqixrQAOEaMFJnGdaNhG9nKT3F+Lz3lx9i6+C5xfC7v?= =?Windows-1252?Q?q8W1qCLKgCbUrvn4I47nKT7J203i0ylVdmlHy6Ruot7c2c3CVFDaxZqA?= =?Windows-1252?Q?92tYGyDIifaC1hPfalf06raBEUag5++S2ngJep/OecGBMoCujWxZ1suX?= =?Windows-1252?Q?8prJDY4m4NU?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB1442; 5:ZN27MrIeZYCdaG2jQwswbYoCU4gtnvAok2pmvxsv00/iLhPv/QDvfj3qT9bZUWp0K1lkEfvvgown9Ngb3vhlR7M+kef2rBCv7g/9htjIvWld6FKuTEkzgs9Wl8LMdZRdvT8mG4hQdRG2jwH8HTtIMg==; 24:w854VshfZ8Na1EV3a4XUZu9uSP2Bs1x8QF3Hc1Wfh9BOAZaVC4C5uNN0LnL5DdOiIeCJdrcIdymFJSCr/NGIskhLUD9nqF2mWuGLmbnRDAQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2016 15:33:34.9717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB1442 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 15:33:38 -0000 W dniu 28.01.2016 o 14:52, Thomas Monjalon pisze: > 2016-01-28 12:17, Kamil Rytarowski: > [...] >>>> + # special case for vfio_pci (module is named vfio-pci, >>>> + # but its .ko is named vfio_pci) >>> Isn't it common to have dash replaced by underscore for kernel modules? >>> >> I retained the logic for special case of vfio-pci. At the moment >> (according to my knowledge) there are no other DPDK modules with this >> name replacement. >> >> I checked few example Linux modules and if a module is named with dash, >> it's being replaced to underscore. The modprobe(8) tool can accept both >> names as interchangeable (with dash and underscore). >> >> Would you like to make it a general rule and replace all dashes with >> underscores? > I don't know. Do what you think is best. > Thanks I suggest to leave it as it is. There is no need to add a layer of abstraction for a single known exception. Also, this is out of scope of my patch. Thank you.