From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 59D1893C0 for ; Wed, 3 Feb 2016 08:48:20 +0100 (CET) Received: by mail-pf0-f172.google.com with SMTP id n128so9408959pfn.3 for ; Tue, 02 Feb 2016 23:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:references:cc:to:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=gaFEFp32OJcyvC3ztN3D0nPqV/I+Rn8UpaXmlm91dLU=; b=A+VyvDgeQj22e0K5TGmAuMPWDj7Wjvy41vpOH/ch9h60PedZYdveg7pIaF1rFe83lC 6CHaG0pvlVBcZQ7IM+PzLHJENbVM8ACzDPRB0IvBnuf6aLdhUiNpnkEAwRJHsYb7Vxqg UTOn9onzACjp73I6//Cov+ibMXJG5xoenXdms5ec7Q6xYnHboZEMBa6/MJiSCNS397WQ hcnlyfEbaTqJhJrZrSMEumqfwlPq3iRRQgK16kn33NdKdpdeJ2ipSeQsAUoM0HSyCVfb uWrNgNEp2IUTk8fwrRTwpl/bqLXbuw1uQrioP9tvQsXNS1OR9IXDC01AuybiUY9XjBHz 6esQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:references:cc:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=gaFEFp32OJcyvC3ztN3D0nPqV/I+Rn8UpaXmlm91dLU=; b=PBRACXmNzILTpytuSsQq6aJOH4R+aRN/ZGI8CvUmPUySeapsAy9MMkbPSUvsOgoOYu 2789Z6FHFPEVmcEzkN4zdkFpaucUhDSkNP/8CBcuZqILbCHNdiSFYp0fBcRkeEcifXuV eetf/ruhLVG6kXZO+xQ0EwIaj2bJ36VNigkk+5vRj3IdbNKRDnbJOF64VxSzZvuPv/tE 5g8v/oJs6oTv5Z7AX15e4qocUMY+DKB8grfJHEJpjY6A0VmfvP7zwbBQ303mGNP1JEi/ iiziezI6AQcUVbp7lXEBAoThKdND5peGu+TYQytdcd8CRZ/Hq+KVKo0JdMBMmr8qIS/A PfJw== X-Gm-Message-State: AG10YOS+bvQGXbPpeTWRH3SUYukiwlqgfVmmZyAB0oENzf1VTJqiZhncKxQQRHXVLKkRbA== X-Received: by 10.98.13.150 with SMTP id 22mr119997pfn.143.1454485699791; Tue, 02 Feb 2016 23:48:19 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id 74sm7564795pfs.33.2016.02.02.23.48.18 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Feb 2016 23:48:19 -0800 (PST) References: <1448355603-21275-2-git-send-email-mukawa@igel.co.jp> <1454411922-5597-3-git-send-email-mukawa@igel.co.jp> <20160202234319.GA925@sivlogin002.ir.intel.com> To: Ferruh Yigit From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <56B1B0C1.2070500@igel.co.jp> Date: Wed, 3 Feb 2016 16:48:17 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160202234319.GA925@sivlogin002.ir.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com, yuanhan.liu@intel.com Subject: Re: [dpdk-dev] [PATCH v6 2/2] vhost: Add VHOST PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 07:48:20 -0000 On 2016/02/03 8:43, Ferruh Yigit wrote: > On Tue, Feb 02, 2016 at 08:18:42PM +0900, Tetsuya Mukawa wrote: >> + >> + /* find an ethdev entry */ >> + eth_dev = rte_eth_dev_allocated(name); >> + if (eth_dev == NULL) >> + return -ENODEV; >> + >> + internal = eth_dev->data->dev_private; >> + >> + rte_free(vring_states[internal->port_id]); >> + vring_states[internal->port_id] = NULL; >> + >> + pthread_mutex_lock(&internal_list_lock); >> + TAILQ_REMOVE(&internals_list, internal, next); >> + pthread_mutex_unlock(&internal_list_lock); >> + >> + eth_dev_stop(eth_dev); >> + >> + if ((internal) && (internal->dev_name)) > if "internal" can be NULL, above internal->port_id reference will crash, if can't be NULL no need to check here. > > Hi Ferruh, I guess if internal is NULL, "internal->dev_name" will not be accessed. So it may be ok to stay above code. Tetsuya