From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 0527F2E83 for ; Mon, 8 Feb 2016 16:53:51 +0100 (CET) Received: from pps.filterd (m0000542.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id u18FeNK1000307; Mon, 8 Feb 2016 07:53:51 -0800 Received: from brmwp-exmb11.corp.brocade.com ([208.47.132.227]) by mx0a-000f0801.pphosted.com with ESMTP id 20wh4akqrx-1 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 08 Feb 2016 07:53:50 -0800 Received: from [10.252.128.14] (10.252.128.14) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Mon, 8 Feb 2016 08:53:48 -0700 Message-ID: <56B8BA0A.9050100@brocade.com> Date: Mon, 8 Feb 2016 07:53:46 -0800 From: "Charles (Chas) Williams" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Bruce Richardson , Chas Williams <3chas3@gmail.com> References: <1451522271-16924-1-git-send-email-3chas3@gmail.com> <20160208135101.GA13952@bricha3-MOBL3> In-Reply-To: <20160208135101.GA13952@bricha3-MOBL3> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas13.corp.brocade.com (10.70.36.103) To BRMWP-EXMB11.corp.brocade.com (172.16.59.77) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-02-08_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1602080270 Cc: dev@dpdk.org, sony.chacko@qlogic.com Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 15:53:52 -0000 I am afraid I don't understand what you are asking. This was broken in the commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be On 02/08/2016 05:51 AM, Bruce Richardson wrote: > On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: >> From: "Charles (Chas) Williams" >> >> bnx2x_loop_obtain_resources() returns a struct containing the status and >> the error message. If bnx2x_do_req4pf() fails, it shouldn't return both >> of these fields set to 0 indicating failure and no error. >> >> Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES >> so that bnx2x_loop_obtain_resources() can negotiate reduced resource >> requirments. This requires additional checking around bnx2x_do_req4pf(). >> >> Signed-off-by: Chas Williams <3chas3@gmail.com> >> --- > > Hi Chas, > > can you please provide a commit reference for a fixes line for this patch. [No > need for a V2 just for that alone, just the reference is enough to save me > diving into the git history. I'll manually add the fixes line when committing > to the next-net tree] > > Maintainers, can you please review this patchset and provide feedback or an ACK. > > Regards, > /Bruce >