From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 1EDC391BF for ; Tue, 9 Feb 2016 04:52:34 +0100 (CET) Received: by mail-pf0-f181.google.com with SMTP id e127so25071729pfe.3 for ; Mon, 08 Feb 2016 19:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=Cq8GrlIL6LKUkezR/TOZg2Q0CkNIHgW+hSAG+TKhRJ8=; b=C5qN6Vx5DoQ1bTV2eCQ/7ANvCJK1f3Yr++56B99cd7RGG1+xDxJRcrGb8LvNcUsBuM wBkRhss0iHI+TrmGpAK7RxJBiT5Q0ISEnDtnnhLoacZgJIruWE6MkHy6zaejcS7ipP31 vwv9ppGvDvInBE1r8Osf6eGTqViHB50lAzZtBkpyppUFSIy2YydedHAJWSMvUVGBwvFd 2KwmFh3ltHO/bBQVfgUvu9tBqfxb728UY3YonjE/thyMfi1ipQvtykTJwZ8Lrl6lVu9U U72fMg3GBy4PYXh8UH9t8vEGNhx1OvA91ItzKqj1sVPak7BolvfC4sLiX0wrEBzdHEZn ULYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=Cq8GrlIL6LKUkezR/TOZg2Q0CkNIHgW+hSAG+TKhRJ8=; b=i2uS7bmYbDEMYt0rqrqMVwiElYN7d3Ct0QVnbDMG9hXiZuVawdHfwaw+ioywVrBtxo kDiieDdmY6qFn88/t6lkXAaO/TiXopYDsyn/uYn+ZXH8LbXT1EqOz2iiUGrCom/tlO3Q drYsjB56y+Sg6OTiEQG3a0IinrAopTxGfy813GO7PK1kjPDPbQ4b8Avotdbn1J3l/QUs G7rWyqi5sfHcOaV1CqF97qX9ZYUQPf3hpxjtV4o1KDN9Z+orJO4sTQL1wV0p/O61YD6n wsg2h8arVOTWMqGOCIOfqvxwsfZwxChk3pMhKddDsrEhcUzBU5M4WLwpybeJlfrVzj/w mptA== X-Gm-Message-State: AG10YOSkn4Vflimi4urpDlM2O5FfvUaPGFP0gayeY8a/CKAnKTB1aYPJvfJGL1dpzv8sNw== X-Received: by 10.98.2.216 with SMTP id 207mr47465372pfc.3.1454989953419; Mon, 08 Feb 2016 19:52:33 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id g10sm46439369pfd.92.2016.02.08.19.52.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Feb 2016 19:52:32 -0800 (PST) To: David Marchand , dev@dpdk.org References: <1454694945-18040-1-git-send-email-david.marchand@6wind.com> <1454831317-4542-1-git-send-email-david.marchand@6wind.com> <1454831317-4542-5-git-send-email-david.marchand@6wind.com> From: Tetsuya Mukawa Message-ID: <56B9627E.6080904@igel.co.jp> Date: Tue, 9 Feb 2016 12:52:30 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454831317-4542-5-git-send-email-david.marchand@6wind.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] virtio: use pci ioport api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2016 03:52:34 -0000 On 2016/02/07 16:48, David Marchand wrote: > Move all os / arch specifics to eal. > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_pci.c | 339 +++++++--------------------------------- > drivers/net/virtio/virtio_pci.h | 38 +---- > 2 files changed, 55 insertions(+), 322 deletions(-) > > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > index b1610dd..e04c0db 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -49,74 +49,35 @@ > > @@ -311,132 +191,20 @@ legacy_virtio_has_msix(const struct rte_pci_addr *loc) > > /* Extract I/O port numbers from sysfs */ > static int > -virtio_resource_init_by_uio(struct rte_pci_device *pci_dev) > +legacy_virtio_resource_init(struct rte_pci_device *pci_dev, > + struct virtio_hw *hw) One more legacy_virtio_resource_init() is defined like below. #ifdef RTE_EXEC_ENV_LINUXAPP #else static int legacy_virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused) { /* no setup required */ return 0; } #endif Should we change this also? Thanks, Tetsuya