From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F0D0E95B5 for ; Fri, 12 Feb 2016 12:52:55 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6B5E9804E4; Fri, 12 Feb 2016 11:52:55 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-99.ams2.redhat.com [10.36.4.99]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1CBqrjU015038; Fri, 12 Feb 2016 06:52:54 -0500 To: Thomas Monjalon , "Wiles, Keith" References: <069176D7-5C83-42E0-B3EC-3119469592BA@intel.com> <1595068.5bg3alq4Oq@xps13> From: Panu Matilainen Message-ID: <56BDC795.6020705@redhat.com> Date: Fri, 12 Feb 2016 13:52:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1595068.5bg3alq4Oq@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Cc: dev@dpdk.org, Neil Horman Subject: Re: [dpdk-dev] [PATCH v2] mempool: reduce rte_mempool structure size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 11:52:56 -0000 On 02/10/2016 08:02 PM, Thomas Monjalon wrote: > 2016-02-10 18:01, Wiles, Keith: >>>>> --- a/config/defconfig_x86_64-native-linuxapp-gcc >>>>> +++ b/config/defconfig_x86_64-native-linuxapp-gcc >>>>> @@ -40,3 +40,8 @@ CONFIG_RTE_ARCH_64=y >>>>> >>>>> CONFIG_RTE_TOOLCHAIN="gcc" >>>>> CONFIG_RTE_TOOLCHAIN_GCC=y >>>>> +CONFIG_RTE_BUILD_SHARED_LIB=y >>>>> +CONFIG_RTE_NEXT_ABI=n >>>>> +CONFIG_RTE_EAL_IGB_UIO=n >>>>> +CONFIG_RTE_LIBRTE_KNI=n >>>>> +CONFIG_RTE_KNI_KMOD=n >>> >>> Hmm, not sure where this came from, but will remove it. >> >> I think this was from the ABI-Checker I ran and the tool should leave the repo in its original state. > > Yes you're right. The ABI checker modify the defconfig instead of modifying > the generated .config file. Its "by design" according to Neil (this was discussed when the abi checker was introduced, see http://dpdk.org/ml/archives/dev/2015-March/014636.html) I actually agree with Neil that changing .config after make config seems counter-intuitive compared to how this works in other projects, but that doesn't make modifying the default templates the right thing to do in DPDK. > Anyone for a patch? I can add it to my TODO among a couple of other things - it should not leave clutter like this behind no matter what. As to how exactly it should be fixed, it could of course just change .config, or alternatively create (and later clean up) a temporary defconfig file with the necessary contents, which would be closer to the current approach I guess. - Panu -