From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 1C51995DA for ; Fri, 12 Feb 2016 16:50:13 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1aUG0I-0000Pc-Cy; Fri, 12 Feb 2016 16:51:30 +0100 To: Thomas Monjalon , "Wiles, Keith" References: <1455039006-86816-1-git-send-email-keith.wiles@intel.com> <56BDEA08.9040402@redhat.com> <09D5A01F-7205-49E8-9A27-95161235963E@intel.com> <10558998.3znIRhOpQL@xps13> From: Olivier MATZ X-Enigmail-Draft-Status: N1110 Message-ID: <56BDFF2B.5090401@6wind.com> Date: Fri, 12 Feb 2016 16:50:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <10558998.3znIRhOpQL@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] mempool: reduce rte_mempool structure size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 15:50:13 -0000 Hi, On 02/12/2016 04:38 PM, Thomas Monjalon wrote: > OK, I'm going to sum it up with new words and let the conclusion comes > from Keith, Panu and Olivier. > > We agreed to allow ABI breaking if a notification was done in the > previous release. > Keith has sent a notification for 16.04 so the "official" ABI will be > changed in 16.07. > It is also encouraged to show how the ABI will be broken when sending > a notification. It allows to give an informed opinion before ack'ing. > The code snippet will also be useful to app developpers when preparing > a future upgrade. > Keith has sent the whole code change. > This code change may be submitted in the current release without waiting > the deprecation time if gated in the NEXT_ABI ifdefs. > It allows to provide the feature to app developpers who don't care about > versioning. But the price is a more complicated code to read and manage. > > To make it short, the rules to use NEXT_ABI are not strict and may change. > So now you have to decide if this change can be integrated in 16.04 > as NEXT_ABI. Thank you Thomas for this summary. Then my vote would be in favor of only keep the deprecation notice for 16.04 and push the code without the NEXT_ABI ifdefs for 16.07 because: - although it's a valuable patch, there is no urgency in having if for the next release - NEXT_ABI does make the code harder to read in this case, and I'm thinking about the patchset from David Hunt (external mempool handler) that will be in the same situation, and maybe also another patchset I'm working on. Regards, Olivier