From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3714ADE6 for ; Mon, 15 Feb 2016 12:56:45 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 8B631C0C234C; Mon, 15 Feb 2016 11:56:44 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-141.ams2.redhat.com [10.36.4.141]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1FBugZ2030636; Mon, 15 Feb 2016 06:56:43 -0500 To: Thomas Monjalon References: <0863DE89-580E-4AA2-B949-25179510BD55@mhcomputing.net> <56C18C78.7080307@redhat.com> <6087984.WHOrx6HCKo@xps13> From: Panu Matilainen Message-ID: <56C1BCFA.7050506@redhat.com> Date: Mon, 15 Feb 2016 13:56:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <6087984.WHOrx6HCKo@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 11:56:45 -0000 On 02/15/2016 12:15 PM, Thomas Monjalon wrote: > 2016-02-15 10:29, Panu Matilainen: >> On 02/14/2016 01:38 AM, Matthew Hall wrote: >>> Hello, >>> >>> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system). > [...] >>> Did anybody run into this before? >> >> Yes, the problem exists at least since DPDK 2.1 but somehow never >> remembered to report / do something about it. >> >> Basically either vm_power_manager example is messing with things its not >> supposed to, or librte_power library isn't exporting everything needed >> to fully use the it. Unfortunately both the library and the example are >> lacking a maintainer :-/ > > Exact, you got the point. > I suggest to disable this feature in your config. I take it you mean disabling librte_power entirely, not just the example? > If it's really annoying, you are allowed to request the removal of the code. > I believe someone would maintain it if he has an interest. I can certainly submit a patch to disable it by default in the configs (seems reasonable unmaintained code would default to off) and add a deprecation note along the lines of "if no maintainer steps up, this code will be removed in 16.07" if you like :) - Panu -