* [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK
@ 2016-02-13 23:38 Matthew Hall
2016-02-15 8:29 ` Panu Matilainen
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Hall @ 2016-02-13 23:38 UTC (permalink / raw)
To: <dev@dpdk.org>
Hello,
I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system).
mhall@mvs-01:~/dpdk/examples/vm_power_manager$ fgrep -ir channel_commands *.{c,h}
channel_manager.c:#include "channel_commands.h"
channel_monitor.c:#include "channel_commands.h"
vm_power_cli.c:#include "channel_commands.h"
channel_manager.h:#include "channel_commands.h"
It appears a bunch of these files are trying to pull in this special header from here:
/home/mhall/src/sdn_sensor/external/dpdk/lib/librte_power/channel_commands.h
However this file is never copied into the include directions in the installed copy. So this example fails to build.
Did anybody run into this before?
Thanks,
Matthew.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK
2016-02-13 23:38 [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK Matthew Hall
@ 2016-02-15 8:29 ` Panu Matilainen
2016-02-15 10:15 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Panu Matilainen @ 2016-02-15 8:29 UTC (permalink / raw)
To: Matthew Hall, <dev@dpdk.org>
On 02/14/2016 01:38 AM, Matthew Hall wrote:
> Hello,
>
> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system).
>
> mhall@mvs-01:~/dpdk/examples/vm_power_manager$ fgrep -ir channel_commands *.{c,h}
> channel_manager.c:#include "channel_commands.h"
> channel_monitor.c:#include "channel_commands.h"
> vm_power_cli.c:#include "channel_commands.h"
> channel_manager.h:#include "channel_commands.h"
>
> It appears a bunch of these files are trying to pull in this special header from here:
>
> /home/mhall/src/sdn_sensor/external/dpdk/lib/librte_power/channel_commands.h
>
> However this file is never copied into the include directions in the installed copy. So this example fails to build.
>
> Did anybody run into this before?
Yes, the problem exists at least since DPDK 2.1 but somehow never
remembered to report / do something about it.
Basically either vm_power_manager example is messing with things its not
supposed to, or librte_power library isn't exporting everything needed
to fully use the it. Unfortunately both the library and the example are
lacking a maintainer :-/
- Panu -
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK
2016-02-15 8:29 ` Panu Matilainen
@ 2016-02-15 10:15 ` Thomas Monjalon
2016-02-15 11:56 ` Panu Matilainen
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2016-02-15 10:15 UTC (permalink / raw)
To: Panu Matilainen; +Cc: dev
2016-02-15 10:29, Panu Matilainen:
> On 02/14/2016 01:38 AM, Matthew Hall wrote:
> > Hello,
> >
> > I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system).
[...]
> > Did anybody run into this before?
>
> Yes, the problem exists at least since DPDK 2.1 but somehow never
> remembered to report / do something about it.
>
> Basically either vm_power_manager example is messing with things its not
> supposed to, or librte_power library isn't exporting everything needed
> to fully use the it. Unfortunately both the library and the example are
> lacking a maintainer :-/
Exact, you got the point.
I suggest to disable this feature in your config.
If it's really annoying, you are allowed to request the removal of the code.
I believe someone would maintain it if he has an interest.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK
2016-02-15 10:15 ` Thomas Monjalon
@ 2016-02-15 11:56 ` Panu Matilainen
2016-02-15 13:21 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Panu Matilainen @ 2016-02-15 11:56 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On 02/15/2016 12:15 PM, Thomas Monjalon wrote:
> 2016-02-15 10:29, Panu Matilainen:
>> On 02/14/2016 01:38 AM, Matthew Hall wrote:
>>> Hello,
>>>
>>> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system).
> [...]
>>> Did anybody run into this before?
>>
>> Yes, the problem exists at least since DPDK 2.1 but somehow never
>> remembered to report / do something about it.
>>
>> Basically either vm_power_manager example is messing with things its not
>> supposed to, or librte_power library isn't exporting everything needed
>> to fully use the it. Unfortunately both the library and the example are
>> lacking a maintainer :-/
>
> Exact, you got the point.
> I suggest to disable this feature in your config.
I take it you mean disabling librte_power entirely, not just the example?
> If it's really annoying, you are allowed to request the removal of the code.
> I believe someone would maintain it if he has an interest.
I can certainly submit a patch to disable it by default in the configs
(seems reasonable unmaintained code would default to off) and add a
deprecation note along the lines of "if no maintainer steps up, this
code will be removed in 16.07" if you like :)
- Panu -
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK
2016-02-15 11:56 ` Panu Matilainen
@ 2016-02-15 13:21 ` Thomas Monjalon
2016-02-15 18:03 ` Mcnamara, John
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2016-02-15 13:21 UTC (permalink / raw)
To: Panu Matilainen, Alan Carew, Pablo de Lara; +Cc: dev
2016-02-15 13:56, Panu Matilainen:
> On 02/15/2016 12:15 PM, Thomas Monjalon wrote:
> > 2016-02-15 10:29, Panu Matilainen:
> >> On 02/14/2016 01:38 AM, Matthew Hall wrote:
> >>> Hello,
> >>>
> >>> I found a peculiarity in the vm_power_manager example on DPDK 2.2 if you use an installed copy of DPDK to compile the examples instead of the master copy (while trying to update some outdated stuff in my build system).
> > [...]
> >>> Did anybody run into this before?
> >>
> >> Yes, the problem exists at least since DPDK 2.1 but somehow never
> >> remembered to report / do something about it.
> >>
> >> Basically either vm_power_manager example is messing with things its not
> >> supposed to, or librte_power library isn't exporting everything needed
> >> to fully use the it. Unfortunately both the library and the example are
> >> lacking a maintainer :-/
> >
> > Exact, you got the point.
> > I suggest to disable this feature in your config.
>
> I take it you mean disabling librte_power entirely, not just the example?
Yes
> > If it's really annoying, you are allowed to request the removal of the code.
> > I believe someone would maintain it if he has an interest.
>
> I can certainly submit a patch to disable it by default in the configs
> (seems reasonable unmaintained code would default to off) and add a
> deprecation note along the lines of "if no maintainer steps up, this
> code will be removed in 16.07" if you like :)
Before sending such notice, we should wait for comments of some known
contributors to librte_power.
Alan, Pablo, what is your opinion?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK
2016-02-15 13:21 ` Thomas Monjalon
@ 2016-02-15 18:03 ` Mcnamara, John
0 siblings, 0 replies; 6+ messages in thread
From: Mcnamara, John @ 2016-02-15 18:03 UTC (permalink / raw)
To: Thomas Monjalon, Panu Matilainen, Carew, Alan, De Lara Guarch, Pablo; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, February 15, 2016 1:21 PM
> To: Panu Matilainen <pmatilai@redhat.com>; Carew, Alan
> <alan.carew@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] vm_power_manager uses channel_commands.h which is
> not placed in installed copy of DPDK
>
>
> > I can certainly submit a patch to disable it by default in the configs
> > (seems reasonable unmaintained code would default to off) and add a
> > deprecation note along the lines of "if no maintainer steps up, this
> > code will be removed in 16.07" if you like :)
>
> Before sending such notice, we should wait for comments of some known
> contributors to librte_power.
> Alan, Pablo, what is your opinion?
Hi,
We will look from a maintainer from the Intel DPDK team and try resolve the
open issues.
Regards,
John
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-15 18:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-13 23:38 [dpdk-dev] vm_power_manager uses channel_commands.h which is not placed in installed copy of DPDK Matthew Hall
2016-02-15 8:29 ` Panu Matilainen
2016-02-15 10:15 ` Thomas Monjalon
2016-02-15 11:56 ` Panu Matilainen
2016-02-15 13:21 ` Thomas Monjalon
2016-02-15 18:03 ` Mcnamara, John
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).