From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C925CAA37 for ; Tue, 16 Feb 2016 08:38:51 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4BAB2804E7; Tue, 16 Feb 2016 07:38:51 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-150.ams2.redhat.com [10.36.4.150]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1G7cos8017124; Tue, 16 Feb 2016 02:38:50 -0500 To: Ziye Yang , dev@dpdk.org References: <1455592571-3554-1-git-send-email-ziye.yang@intel.com> From: Panu Matilainen Message-ID: <56C2D209.8000303@redhat.com> Date: Tue, 16 Feb 2016 09:38:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455592571-3554-1-git-send-email-ziye.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Subject: Re: [dpdk-dev] [PATCH v2] PCI: ABI change request for adding new field in rte_pci_id structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 07:38:52 -0000 On 02/16/2016 05:16 AM, Ziye Yang wrote: > From: Ziye > > The purpose of this patch is used to add a new field > "class" in rte_pci_id structure. The new class field includes > class_id, subcalss_id, programming interface of a pci device. > With this field, we can identify pci device by its class info, > which can be more flexible instead of probing the device by > vendor_id OR device_id OR subvendor_id OR subdevice_id. > For example, we can probe all nvme devices by class field, which > can be quite convenient. > > Signed-off-by: Ziye Yang > --- > doc/guides/rel_notes/release_16_04.rst | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst > index 27fc624..fe843a5 100644 > --- a/doc/guides/rel_notes/release_16_04.rst > +++ b/doc/guides/rel_notes/release_16_04.rst > @@ -95,9 +95,10 @@ This section should contain API changes. Sample format: > ABI Changes > ----------- > > -* Add a short 1-2 sentence description of the ABI change that was announced in > - the previous releases and made in this release. Use fixed width quotes for > - ``rte_function_names`` or ``rte_struct_names``. Use the past tense. > +* New field ``class`` is added into ``rte_pci_id`` structure. This new > + added ``class`` field can be used to probe pci devices by class related > + info. With this new field, the size of structure ``rte_pci_device`` will > + be increased. > > > Shared Library Versions > ABI breakage announcements go into doc/guides/rel_notes/deprecation.rst, see the examples there. Also you can't break the ABI in the version under development but only the next one, so right now the earliest ABI breakage opportunity is in the release *after* 16.04, which is supposed to be 16.07 according to the roadmap. - Panu -