From: Nicolas Pernas Maradei <nicolas.pernas.maradei@emutex.com>
To: Dror Birkman <dror.birkman@lightcyber.com>, john.mcnamara@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pcap: fix captured frame length
Date: Wed, 17 Feb 2016 10:18:52 +0000 [thread overview]
Message-ID: <56C4490C.20401@emutex.com> (raw)
In-Reply-To: <1453979390-36685-1-git-send-email-dror.birkman@lightcyber.com>
Hi,
I'm just adding the Acked-by line to the patch. Apologise I missed that one earlier.
Nico.
On 28/01/16 11:09, Dror Birkman wrote:
> The actual captured length is header.caplen, whereas header.len is
> the original length on the wire.
>
> Signed-off-by: Dror Birkman <dror.birkman@lightcyber.com>
> Acked-by: Nicolas Pernas Maradei <nicolas.pernas.maradei@emutex.com>
> ---
>
>
> Without this fix, if the captured length is smaller than the original
> length on the wire, mbuf will contain incorrect data.
>
>
> drivers/net/pcap/rte_eth_pcap.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
> index f9230eb..1d121f8 100644
> --- a/drivers/net/pcap/rte_eth_pcap.c
> +++ b/drivers/net/pcap/rte_eth_pcap.c
> @@ -220,25 +220,25 @@ eth_pcap_rx(void *queue,
> buf_size = (uint16_t)(rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
> RTE_PKTMBUF_HEADROOM);
>
> - if (header.len <= buf_size) {
> + if (header.caplen <= buf_size) {
> /* pcap packet will fit in the mbuf, go ahead and copy */
> rte_memcpy(rte_pktmbuf_mtod(mbuf, void *), packet,
> - header.len);
> - mbuf->data_len = (uint16_t)header.len;
> + header.caplen);
> + mbuf->data_len = (uint16_t)header.caplen;
> } else {
> /* Try read jumbo frame into multi mbufs. */
> if (unlikely(eth_pcap_rx_jumbo(pcap_q->mb_pool,
> mbuf,
> packet,
> - header.len) == -1))
> + header.caplen) == -1))
> break;
> }
>
> - mbuf->pkt_len = (uint16_t)header.len;
> + mbuf->pkt_len = (uint16_t)header.caplen;
> mbuf->port = pcap_q->in_port;
> bufs[num_rx] = mbuf;
> num_rx++;
> - rx_bytes += header.len;
> + rx_bytes += header.caplen;
> }
> pcap_q->rx_pkts += num_rx;
> pcap_q->rx_bytes += rx_bytes;
next prev parent reply other threads:[~2016-02-17 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:09 Dror Birkman
2016-01-28 18:14 ` Nicolas Pernas Maradei
2016-02-16 15:31 ` Bruce Richardson
2016-03-09 18:42 ` Bruce Richardson
2016-02-17 10:18 ` Nicolas Pernas Maradei [this message]
[not found] <1453968561-29085-1-git-send-email-dror.birkman@lightcyber.com>
[not found] ` <56AA5746.5030401@emutex.com>
2016-01-30 13:38 ` Dror Birkman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4490C.20401@emutex.com \
--to=nicolas.pernas.maradei@emutex.com \
--cc=dev@dpdk.org \
--cc=dror.birkman@lightcyber.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).